third_party/WebKit/Source/core/layout/LayoutMenuList.cpp - Issue 2939933002: Only call TextChanged on existing AXObjects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Issue 2939933002: Only call TextChanged on existing AXObjects (Closed)

Patch Set: Update test expectation Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

index 965037436f3b80858aea4f3644d58aa7322a84e1..6b6590a444072544f855a430799f94483bf38872 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

@@ -308,9 +308,6 @@ void LayoutMenuList::DidUpdateActiveOption(HTMLOptionElement* option) {

return;

last_active_index_ = option_index;

- if (option_index < 0)

- return;

// We skip sending accessiblity notifications for the very first option,

// otherwise we get extra focus and select events that are undesired.

if (!has_updated_active_option_) {