Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: net/url_request/url_request_context_builder.cc

Issue 2939733002: Add some docs to URLRequestContextBuilder. (Closed)
Patch Set: Response to comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_context_builder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context_builder.cc
diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc
index 85a19f401ad5d3bb124fdcd8a7de6a78df4321ff..638253e99f1e3c2c6b39eab298a00b01b73d9cbd 100644
--- a/net/url_request/url_request_context_builder.cc
+++ b/net/url_request/url_request_context_builder.cc
@@ -134,9 +134,11 @@ class BasicNetworkDelegate : public NetworkDelegateImpl {
DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
};
-// Define a context class that can self-manage the ownership of its components
-// via a UrlRequestContextStorage object. Since it cancels requests in its
-// destructor, it's not safe to subclass this.
+// A URLRequestContext subclass that owns most of its components
+// via a UrlRequestContextStorage object. When URLRequestContextBuilder::Build()
+// is called, ownership of all URLRequestContext components is passed to the
+// ContainerURLRequestContext. Since this cancels requests in its destructor,
+// it's not safe to subclass this.
class ContainerURLRequestContext final : public URLRequestContext {
public:
explicit ContainerURLRequestContext(
« no previous file with comments | « net/url_request/url_request_context_builder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698