Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2939673002: Update the button visibility when mouse enters or exits from notification surface window (Closed)

Created:
3 years, 6 months ago by yoshiki
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Update the button visibility when mouse enters or exits from notification surface window The outer view's ONMOUSEENTERED/EXITED are not called on toast, so we need to handle the window's event handlers. BUG=728915 TEST=manual (issue is not happened) Review-Url: https://codereview.chromium.org/2922643002 Cr-Commit-Position: refs/heads/master@{#477927} (cherry picked from commit 7b1b44becb55f7920992b9027307531932f83ce7) Review-Url: https://codereview.chromium.org/2939673002 . Cr-Commit-Position: refs/branch-heads/3112@{#314} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ee53fcd185bc5a713a76bda3d8836328e4952426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 6 months ago (2017-06-13 04:37:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee53fcd185bc5a713a76bda3d8836328e4952426.

Powered by Google App Engine
This is Rietveld 408576698