Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2922643002: Update the button visibility when mouse enters or exits from notification surface window (Closed)

Created:
3 years, 6 months ago by yoshiki
Modified:
3 years, 6 months ago
Reviewers:
yhanada
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the button visibility when mouse enters or exits from notification surface window The outer view's ONMOUSEENTERED/EXITED are not called on toast, so we need to handle the window's event handlers. BUG=728915 TEST=manual (issue is not happened) Review-Url: https://codereview.chromium.org/2922643002 Cr-Commit-Position: refs/heads/master@{#477927} Committed: https://chromium.googlesource.com/chromium/src/+/7b1b44becb55f7920992b9027307531932f83ce7

Patch Set 1 #

Patch Set 2 : early return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/arc/notification/arc_notification_content_view.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
yoshiki
Hanada-san, PTAL. Thanks.
3 years, 6 months ago (2017-06-06 09:33:09 UTC) #9
yoshiki
As offline discussion with Hanada-san, it looks the root cause is deeper than I thought. ...
3 years, 6 months ago (2017-06-06 11:08:04 UTC) #12
yhanada
lgtm
3 years, 6 months ago (2017-06-08 08:27:41 UTC) #13
yoshiki
On 2017/06/08 08:27:41, yhanada wrote: > lgtm Thanks! As we discussed offline, thoug, this patch ...
3 years, 6 months ago (2017-06-08 08:34:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922643002/20001
3 years, 6 months ago (2017-06-08 08:34:35 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 09:02:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b1b44becb55f7920992b9027307...

Powered by Google App Engine
This is Rietveld 408576698