Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293963003: Remove ScriptObject (Closed)

Created:
6 years, 7 months ago by haraken
Modified:
6 years, 7 months ago
CC:
blink-reviews, tzik, apavlov+blink_chromium.org, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, falken, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, nhiroki, alecflett+watch_chromium.org, serviceworker-reviews, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, horo+watch_chromium.org, sergeyv+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove ScriptObject ScriptObject is a class that holds a ScriptState and a ScriptValue. However, now that the ScriptValue knows the ScriptState, we no longer need the ScriptObject. Thus this CL completely replaces ScriptObject with ScriptValue. BUG=357144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174471

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -136 lines) Patch
M Source/bindings/v8/ScriptDebugServer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.h View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 6 chunks +8 lines, -13 lines 0 comments Download
M Source/bindings/v8/ScriptObject.h View 1 chunk +2 lines, -14 lines 0 comments Download
M Source/bindings/v8/ScriptObject.cpp View 3 chunks +2 lines, -29 lines 0 comments Download
M Source/bindings/v8/ScriptProfiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptValue.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptBase.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InjectedScriptBase.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptModule.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
This is still WIP. Not yet for review.
6 years, 7 months ago (2014-05-20 15:37:12 UTC) #1
aandrey
https://codereview.chromium.org/293963003/diff/1/Source/core/inspector/PromiseTracker.h File Source/core/inspector/PromiseTracker.h (right): https://codereview.chromium.org/293963003/diff/1/Source/core/inspector/PromiseTracker.h#newcode34 Source/core/inspector/PromiseTracker.h:34: #include "bindings/v8/ScriptValue.h" FYI this file and few more were ...
6 years, 7 months ago (2014-05-20 15:51:40 UTC) #2
haraken
On 2014/05/20 15:51:40, aandrey wrote: > https://codereview.chromium.org/293963003/diff/1/Source/core/inspector/PromiseTracker.h > File Source/core/inspector/PromiseTracker.h (right): > > https://codereview.chromium.org/293963003/diff/1/Source/core/inspector/PromiseTracker.h#newcode34 > ...
6 years, 7 months ago (2014-05-20 15:52:46 UTC) #3
haraken
Tests are passing. PTAL.
6 years, 7 months ago (2014-05-20 20:31:48 UTC) #4
dcarney
the first three files and the last one don't need to be changed. lgtm
6 years, 7 months ago (2014-05-20 20:55:32 UTC) #5
aandrey
https://codereview.chromium.org/293963003/diff/20001/Source/bindings/v8/ScriptValue.h File Source/bindings/v8/ScriptValue.h (right): https://codereview.chromium.org/293963003/diff/20001/Source/bindings/v8/ScriptValue.h#newcode161 Source/bindings/v8/ScriptValue.h:161: struct ScriptValueHash { is this needed?
6 years, 7 months ago (2014-05-21 03:52:02 UTC) #6
yurys
lgtm provided that aandrey's concern is resolved. https://codereview.chromium.org/293963003/diff/20001/Source/core/inspector/InjectedScriptBase.h File Source/core/inspector/InjectedScriptBase.h (right): https://codereview.chromium.org/293963003/diff/20001/Source/core/inspector/InjectedScriptBase.h#newcode62 Source/core/inspector/InjectedScriptBase.h:62: const ScriptValue& ...
6 years, 7 months ago (2014-05-21 06:09:54 UTC) #7
haraken
https://codereview.chromium.org/293963003/diff/20001/Source/bindings/v8/ScriptValue.h File Source/bindings/v8/ScriptValue.h (right): https://codereview.chromium.org/293963003/diff/20001/Source/bindings/v8/ScriptValue.h#newcode161 Source/bindings/v8/ScriptValue.h:161: struct ScriptValueHash { On 2014/05/21 03:52:03, aandrey wrote: > ...
6 years, 7 months ago (2014-05-21 06:45:09 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 7 months ago (2014-05-21 06:45:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/293963003/40001
6 years, 7 months ago (2014-05-21 06:48:07 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:30:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 174471

Powered by Google App Engine
This is Rietveld 408576698