Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: Source/bindings/v8/ScriptValue.h

Issue 293963003: Remove ScriptObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 v8::Handle<v8::Value> v8Value() const 147 v8::Handle<v8::Value> v8Value() const
148 { 148 {
149 return m_value.get() ? m_value->newLocal(isolate()) : v8::Handle<v8::Val ue>(); 149 return m_value.get() ? m_value->newLocal(isolate()) : v8::Handle<v8::Val ue>();
150 } 150 }
151 151
152 bool toString(String&) const; 152 bool toString(String&) const;
153 PassRefPtr<JSONValue> toJSONValue(ScriptState*) const; 153 PassRefPtr<JSONValue> toJSONValue(ScriptState*) const;
154 154
155 private: 155 private:
156 mutable v8::Isolate* m_isolate; 156 mutable v8::Isolate* m_isolate;
157 // FIXME: m_scriptState is not yet used.
158 // We will start using it once we remove ScriptValue(v8::Handle<v8::Value> v alue, v8::Isolate* isolate).
159 mutable RefPtr<ScriptState> m_scriptState; 157 mutable RefPtr<ScriptState> m_scriptState;
160 RefPtr<SharedPersistent<v8::Value> > m_value; 158 RefPtr<SharedPersistent<v8::Value> > m_value;
161 }; 159 };
162 160
161 struct ScriptValueHash {
aandrey 2014/05/21 03:52:03 is this needed?
haraken 2014/05/21 06:45:10 Removed, thanks.
162 static unsigned hash(const ScriptValue& object) { return v8::Handle<v8::Obje ct>::Cast(object.v8Value())->GetIdentityHash(); }
163 static bool equal(const ScriptValue& a, const ScriptValue& b) { return a == b; }
164 static const bool safeToCompareToEmptyOrDeleted = true;
165 };
166
167 struct ScriptValueHashTraits : WTF::GenericHashTraits<ScriptValue> {
168 static const bool emptyValueIsZero = false;
169 static ScriptValue emptyValue() { return ScriptValue(); }
170 static void constructDeletedValue(ScriptValue& slot) { slot = ScriptValue(); }
171 static bool isDeletedValue(ScriptValue value) { return value.isEmpty(); }
172 };
173
163 } // namespace WebCore 174 } // namespace WebCore
164 175
165 #endif // ScriptValue_h 176 #endif // ScriptValue_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698