Issue 2939543002: Refactor SingleLogSource for better test coverage

Issue 2939543002: Refactor SingleLogSource for better test coverage (Closed)

Created:
3 years, 6 months ago by Simon Que

Modified:
3 years, 6 months ago

Reviewers:
afakhry

CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, rkc

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Refactor SingleLogSource for better test coverage Instead of providing a test file handle, provide an entire log file directory based on what is actually on a Chrome OS system. BUG=chromium:731906 TEST=unit test passes Review-Url: https://codereview.chromium.org/2939543002 Cr-Commit-Position: refs/heads/master@{#479112} Committed: https://chromium.googlesource.com/chromium/src/+/966a94e0171ca74455e97cb930d03d235d853895

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -52 lines)			Patch
M	chrome/browser/chromeos/system_logs/single_log_source.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system_logs/single_log_source.cc	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/system_logs/single_log_source_unittest.cc	View	12 chunks	+78 lines, -44 lines	0 comments	Download

Dependent Patchsets:

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939543002/1

3 years, 6 months ago (2017-06-13 19:08:38 UTC) #5

commit-bot: I haz the power

3 years, 6 months ago (2017-06-13 20:01:44 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/966a94e0171ca74455e97cb930d0...