SingleLogSource reads whole lines whenever possible

SingleLogSource reads whole lines whenever possible

Previously, if SingleLogSource found no newline at the end of a read,
it would reset the file read offset and return nothing.

With this patch, it will return as many whole lines with newlines at
the end as it possibly can, and update the file read offset.

BUG=731906
TEST=unit tests pass

Review-Url: https://codereview.chromium.org/2930383002
Cr-Commit-Position: refs/heads/master@{#479154}
Committed: https://chromium.googlesource.com/chromium/src/+/b68e3bed1ed8f2b84cbc53c8ce9a3dc7a2536858

[Simon Que, 2017-06-12 21:53:00]

sque@chromium.org changed reviewers:
+ afakhry@chromium.org

[afakhry, 2017-06-13 17:16:13]

lgtm

[Simon Que, 2017-06-13 19:26:21]

The CQ bit was checked by sque@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 19:26:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 19:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 19:59:06]

Dry run: This issue passed the CQ dry run.

[Simon Que, 2017-06-13 21:15:24]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:16:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:20:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497388524043780, "parent_rev":
"2a64e2319ac7fdc7a7a856c797fa2565656e92dd", "commit_rev":
"b68e3bed1ed8f2b84cbc53c8ce9a3dc7a2536858"}

[commit-bot: I haz the power, 2017-06-13 21:20:42]

Description was changed from

==========
SingleLogSource reads whole lines whenever possible

Previously, if SingleLogSource found no newline at the end of a read,
it would reset the file read offset and return nothing.

With this patch, it will return as many whole lines with newlines at
the end as it possibly can, and update the file read offset.

BUG=731906
TEST=unit tests pass
==========

to

==========
SingleLogSource reads whole lines whenever possible

Previously, if SingleLogSource found no newline at the end of a read,
it would reset the file read offset and return nothing.

With this patch, it will return as many whole lines with newlines at
the end as it possibly can, and update the file read offset.

BUG=731906
TEST=unit tests pass

Review-Url: https://codereview.chromium.org/2930383002
Cr-Commit-Position: refs/heads/master@{#479154}
Committed:
https://chromium.googlesource.com/chromium/src/+/b68e3bed1ed8f2b84cbc53c8ce9a...
==========

[commit-bot: I haz the power, 2017-06-13 21:20:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b68e3bed1ed8f2b84cbc53c8ce9a...