[CSS Typed OM] Make the attributes of CSSPerspective mutable.

[CSS Typed OM] Make the attributes of CSSPerspective mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssperspective

BUG=545318
Review-Url: https://codereview.chromium.org/2939273003
Cr-Commit-Position: refs/heads/master@{#481483}
Committed: https://chromium.googlesource.com/chromium/src/+/e59bf2584a90988c985df4e15fe898b4dbe5eedf

[meade_UTC10, 2017-06-16 07:13:04]

Description was changed from

==========
[CSS Typed OM] Make the attributes of CSSPerspective mutable.

BUG=545318
==========

to

==========
[CSS Typed OM] Make the attributes of CSSPerspective mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssperspective

BUG=545318
==========

[meade_UTC10, 2017-06-16 07:18:21]

meade@chromium.org changed reviewers:
+ alancutter@chromium.org

[meade_UTC10, 2017-06-16 07:18:22]

Hi Alan, I split this off from the other CL too. PTAL

[alancutter (OOO until 2018), 2017-06-19 04:27:18]

lgtm

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSPerspective.h (left):

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSPerspective.h:32: // Bindings
require a non const return value.
I think this comment is useful, I'd be in favour of keeping it to explain the
weird constness here.
I'd even consider making these getters non-const if it's not needed for
anything.

[meade_UTC10, 2017-06-19 08:07:40]

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSPerspective.h (left):

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSPerspective.h:32: // Bindings
require a non const return value.
On 2017/06/19 04:27:18, alancutter wrote:
> I think this comment is useful, I'd be in favour of keeping it to explain the
> weird constness here.
> I'd even consider making these getters non-const if it's not needed for
> anything.

I removed the comment because we no longer need the const_cast, which is what it
was referring to?

[alancutter (OOO until 2018), 2017-06-19 10:55:12]

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSPerspective.h (left):

https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSPerspective.h:32: // Bindings
require a non const return value.
On 2017/06/19 at 08:07:40, meade_UTC10 wrote:
> On 2017/06/19 04:27:18, alancutter wrote:
> > I think this comment is useful, I'd be in favour of keeping it to explain
the
> > weird constness here.
> > I'd even consider making these getters non-const if it's not needed for
> > anything.
> 
> I removed the comment because we no longer need the const_cast, which is what
it was referring to?

It's the fact that it's returning non-const member pointers from const getters
that's worth justifying with a comment.
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Use-co...

[meade_UTC10, 2017-06-22 04:06:27]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-22 04:06:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939273003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-22 04:06:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-06-22 04:06:51]

On 2017/06/19 10:55:12, alancutter wrote:
>
https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/cssom/CSSPerspective.h (left):
> 
>
https://codereview.chromium.org/2939273003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/cssom/CSSPerspective.h:32: // Bindings
> require a non const return value.
> On 2017/06/19 at 08:07:40, meade_UTC10 wrote:
> > On 2017/06/19 04:27:18, alancutter wrote:
> > > I think this comment is useful, I'd be in favour of keeping it to explain
> the
> > > weird constness here.
> > > I'd even consider making these getters non-const if it's not needed for
> > > anything.
> > 
> > I removed the comment because we no longer need the const_cast, which is
what
> it was referring to?
> 
> It's the fact that it's returning non-const member pointers from const getters
> that's worth justifying with a comment.
>
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Use-co...

I just made https://chromium-review.googlesource.com/c/544576/ to fix them all
at once.

[meade_UTC10, 2017-06-22 04:07:07]

The CQ bit was unchecked by meade@chromium.org

[meade_UTC10, 2017-06-22 04:09:50]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-22 04:09:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939273003/#ps80001
(title: "remove const")

[commit-bot: I haz the power, 2017-06-22 04:09:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-06-22 06:11:52]

The CQ bit was unchecked by meade@chromium.org

[meade_UTC10, 2017-06-22 06:43:23]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-06-22 06:43:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939273003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-22 06:43:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 09:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498113803736560,
"parent_rev": "e82ecb088efcd8a4f8d28e6ff8b9185c2ba90f16", "commit_rev":
"e59bf2584a90988c985df4e15fe898b4dbe5eedf"}

[commit-bot: I haz the power, 2017-06-22 09:01:42]

Description was changed from

==========
[CSS Typed OM] Make the attributes of CSSPerspective mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssperspective

BUG=545318
==========

to

==========
[CSS Typed OM] Make the attributes of CSSPerspective mutable.

Spec: https://drafts.css-houdini.org/css-typed-om/#cssperspective

BUG=545318

Review-Url: https://codereview.chromium.org/2939273003
Cr-Commit-Position: refs/heads/master@{#481483}
Committed:
https://chromium.googlesource.com/chromium/src/+/e59bf2584a90988c985df4e15fe8...
==========

[commit-bot: I haz the power, 2017-06-22 09:01:43]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e59bf2584a90988c985df4e15fe8...