Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

Issue 2939273003: [CSS Typed OM] Make the attributes of CSSPerspective mutable. (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSPerspective.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h
index 082fd31d6ca89385000428e1c540cf6705a2a16d..990911511f7e1df0c562a9361f27332a8b00cbe8 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h
@@ -17,7 +17,7 @@ class ExceptionState;
// Represents a perspective value in a CSSTransformValue used for properties
// like "transform".
// See CSSPerspective.idl for more information about this class.
-class CORE_EXPORT CSSPerspective : public CSSTransformComponent {
+class CORE_EXPORT CSSPerspective final : public CSSTransformComponent {
WTF_MAKE_NONCOPYABLE(CSSPerspective);
DEFINE_WRAPPERTYPEINFO();
@@ -29,16 +29,14 @@ class CORE_EXPORT CSSPerspective : public CSSTransformComponent {
static CSSPerspective* FromCSSValue(const CSSFunctionValue&);
// Getters and setters for attributes defined in the IDL.
- // Bindings require a non const return value.
- CSSNumericValue* length() const {
- return const_cast<CSSNumericValue*>(length_.Get());
- }
+ CSSNumericValue* length() { return length_.Get(); }
+ void setLength(CSSNumericValue*, ExceptionState&);
// Internal methods - from CSSTransformComponent.
- TransformComponentType GetType() const override { return kPerspectiveType; }
+ TransformComponentType GetType() const final { return kPerspectiveType; }
// TODO: Implement AsMatrix for CSSPerspective.
- DOMMatrix* AsMatrix() const override { return nullptr; }
- CSSFunctionValue* ToCSSValue() const override;
+ DOMMatrix* AsMatrix() const final { return nullptr; }
+ CSSFunctionValue* ToCSSValue() const final;
DEFINE_INLINE_VIRTUAL_TRACE() {
visitor->Trace(length_);
@@ -46,9 +44,9 @@ class CORE_EXPORT CSSPerspective : public CSSTransformComponent {
}
private:
- CSSPerspective(const CSSNumericValue* length) : length_(length) {}
+ CSSPerspective(CSSNumericValue* length) : length_(length) {}
- Member<const CSSNumericValue> length_;
+ Member<CSSNumericValue> length_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698