Add DocumentShutdown{Notifier,Observer}

Add DocumentShutdown{Notifier,Observer}

This is a subclass of LifecycleNotifier that classes can use to be notified when
the Document they're attached to is shut down.
SynchronousMutation{Notifier,Observer} provides the same functionality but is
more performance sensitive because it also gets notified when
Node::appendChild() and Node::removeChild() are called.

The idea to add this came from the code review of this CL:
https://codereview.chromium.org/2931443003#msg72

BUG=715365
Review-Url: https://codereview.chromium.org/2939223003
Cr-Commit-Position: refs/heads/master@{#480164}
Committed: https://chromium.googlesource.com/chromium/src/+/afd1411d6b0dbb13fc94314c745755fd76bd763b

[rlanday, 2017-06-15 23:40:27]

Description was changed from

==========
codere# This will be displayed on the codereview site.
Add DocumentShutdown{Notifier,Observer}

This is a subclass of LifecycleNotifier that classes can use to be notified when
the Document they're attached to is shut down.
SynchronousMutation{Notifier,Observer} provides the same functionality but is
more performance sensitive because it also gets notified when
Node::appendChild() and Node::removeChild() are called.

The idea to add this came from the code review of this CL:
https://codereview.chromium.org/2931443003#msg72

BUG=715365
==========

to

==========
Add DocumentShutdown{Notifier,Observer}

This is a subclass of LifecycleNotifier that classes can use to be notified when
the Document they're attached to is shut down.
SynchronousMutation{Notifier,Observer} provides the same functionality but is
more performance sensitive because it also gets notified when
Node::appendChild() and Node::removeChild() are called.

The idea to add this came from the code review of this CL:
https://codereview.chromium.org/2931443003#msg72

BUG=715365
==========

[rlanday, 2017-06-15 23:40:27]

rlanday@chromium.org changed reviewers:
+ skobes@chromium.org, yosin@chromium.org

[rlanday, 2017-06-15 23:53:35]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 23:53:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 00:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 00:00:42]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[yosin_UTC9, 2017-06-16 01:06:22]

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DocumentShutdownNotifier.h (right):

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DocumentShutdownNotifier.h:15: class
DocumentShutdownNotifier
Could you add class level comment?

It seems DocumentShutdownNotifier needs to have CORE_EXPORT, see win bot's
compilation failure.

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h (right):

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h:20: 
nit: Please remove an extra blank line.

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h:25: virtual void
ContextDestroyed(Document*) {}
Please move an implementation to .cpp file[1]

https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h:32: };
nit: Please add a blank line between class declaration and namespace closing
brace.

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h:33: }
nit: s|}|}  // namespace blink|

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/SynchronousMutationObserver.h (right):

https://codereview.chromium.org/2939223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/SynchronousMutationObserver.h:23: // Note: if
you only need to observe Document shutdown,
Thanks for adding this notice!

[rlanday, 2017-06-16 01:28:10]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 01:28:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-16 01:28:58]

Updated

[yosin_UTC9, 2017-06-16 01:30:48]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-16 01:30:48]

lgtm

+tken@ for OWNERS review.

[tkent, 2017-06-16 01:35:57]

lgtm

[commit-bot: I haz the power, 2017-06-16 02:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 02:16:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skobes, 2017-06-16 17:57:35]

lgtm

[rlanday, 2017-06-16 18:27:15]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 18:27:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 20:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 20:59:11]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-06-16 20:59:58]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-16 20:59:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
skobes@chromium.org, yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2939223003/#ps40001
(title: "Add CORE_EXPORT to DocumentShutdownNotifier")

[commit-bot: I haz the power, 2017-06-16 21:00:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 21:06:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497646798122180,
"parent_rev": "5328f007181fe5acd3d913e0fa4ada0cb4dff483", "commit_rev":
"4322a973ae1ab8737e7260de2bbabe05626fff9f"}

[commit-bot: I haz the power, 2017-06-16 21:07:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497646798122180,
"parent_rev": "cf00b10856b2283ce6bcc8413acc1f37a651829f", "commit_rev":
"afd1411d6b0dbb13fc94314c745755fd76bd763b"}

[commit-bot: I haz the power, 2017-06-16 21:07:28]

Description was changed from

==========
Add DocumentShutdown{Notifier,Observer}

This is a subclass of LifecycleNotifier that classes can use to be notified when
the Document they're attached to is shut down.
SynchronousMutation{Notifier,Observer} provides the same functionality but is
more performance sensitive because it also gets notified when
Node::appendChild() and Node::removeChild() are called.

The idea to add this came from the code review of this CL:
https://codereview.chromium.org/2931443003#msg72

BUG=715365
==========

to

==========
Add DocumentShutdown{Notifier,Observer}

This is a subclass of LifecycleNotifier that classes can use to be notified when
the Document they're attached to is shut down.
SynchronousMutation{Notifier,Observer} provides the same functionality but is
more performance sensitive because it also gets notified when
Node::appendChild() and Node::removeChild() are called.

The idea to add this came from the code review of this CL:
https://codereview.chromium.org/2931443003#msg72

BUG=715365

Review-Url: https://codereview.chromium.org/2939223003
Cr-Commit-Position: refs/heads/master@{#480164}
Committed:
https://chromium.googlesource.com/chromium/src/+/afd1411d6b0dbb13fc94314c7457...
==========

[commit-bot: I haz the power, 2017-06-16 21:07:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/afd1411d6b0dbb13fc94314c7457...