Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/DocumentShutdownObserver.h

Issue 2939223003: Add DocumentShutdown{Notifier,Observer} (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved. Use of
2 // this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef DocumentShutdownObserver_h
6 #define DocumentShutdownObserver_h
7
8 #include "core/CoreExport.h"
9 #include "platform/LifecycleObserver.h"
10
11 namespace blink {
12
13 class Document;
14
15 // This class is a base class for classes which observe Document shutdown
16 // synchronously.
17 // Note: this functionality is also provided by SynchronousMutationObserver,
18 // but if you don't need to respond to the other events handled by that class,
19 // using this class is more efficient.
20
yosin_UTC9 2017/06/16 01:06:21 nit: Please remove an extra blank line.
21 class CORE_EXPORT DocumentShutdownObserver
22 : public LifecycleObserver<Document, DocumentShutdownObserver> {
23 public:
24 // Called when detaching document.
25 virtual void ContextDestroyed(Document*) {}
yosin_UTC9 2017/06/16 01:06:21 Please move an implementation to .cpp file[1] htt
26
27 protected:
28 DocumentShutdownObserver();
29
30 private:
31 DISALLOW_COPY_AND_ASSIGN(DocumentShutdownObserver);
32 };
yosin_UTC9 2017/06/16 01:06:21 nit: Please add a blank line between class declara
33 }
yosin_UTC9 2017/06/16 01:06:21 nit: s|}|} // namespace blink|
34
35 #endif // DocumentShutdownObserver_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698