Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2939163003: Removing unused HasHorizontal/VerticalScrollbar methods from WebFrame. (Closed)

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused HasHorizontal/VerticalScrollbar methods from WebFrame. The HasHorizontalScrollbar and HasVerticalScrollbar virtual methods from blink::WebFrame do not have any callers and can be safely removed. No intended behavior change. BUG=416660 Review-Url: https://codereview.chromium.org/2939163003 Cr-Commit-Position: refs/heads/master@{#479915} Committed: https://chromium.googlesource.com/chromium/src/+/91ab6673c25ea8402f9ed2deb2ed015b914605f4

Patch Set 1 #

Patch Set 2 : Just removing the methods altogether also seems to works... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Łukasz Anforowicz
dcheng@, can you PTAL?
3 years, 6 months ago (2017-06-15 22:44:24 UTC) #6
dcheng
lgtm
3 years, 6 months ago (2017-06-15 22:46:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939163003/20001
3 years, 6 months ago (2017-06-15 22:46:58 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 02:00:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91ab6673c25ea8402f9ed2deb2ed...

Powered by Google App Engine
This is Rietveld 408576698