Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

Issue 2939163003: Removing unused HasHorizontal/VerticalScrollbar methods from WebFrame. (Closed)
Patch Set: Just removing the methods altogether also seems to works... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/exported/WebRemoteFrameImpl.h" 5 #include "core/exported/WebRemoteFrameImpl.h"
6 6
7 #include "bindings/core/v8/WindowProxy.h" 7 #include "bindings/core/v8/WindowProxy.h"
8 #include "core/dom/Fullscreen.h" 8 #include "core/dom/Fullscreen.h"
9 #include "core/dom/RemoteSecurityContext.h" 9 #include "core/dom/RemoteSecurityContext.h"
10 #include "core/dom/SecurityContext.h" 10 #include "core/dom/SecurityContext.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 bool WebRemoteFrameImpl::HasVisibleContent() const { 107 bool WebRemoteFrameImpl::HasVisibleContent() const {
108 NOTREACHED(); 108 NOTREACHED();
109 return false; 109 return false;
110 } 110 }
111 111
112 WebRect WebRemoteFrameImpl::VisibleContentRect() const { 112 WebRect WebRemoteFrameImpl::VisibleContentRect() const {
113 NOTREACHED(); 113 NOTREACHED();
114 return WebRect(); 114 return WebRect();
115 } 115 }
116 116
117 bool WebRemoteFrameImpl::HasHorizontalScrollbar() const {
118 NOTREACHED();
119 return false;
120 }
121
122 bool WebRemoteFrameImpl::HasVerticalScrollbar() const {
123 NOTREACHED();
124 return false;
125 }
126
127 WebView* WebRemoteFrameImpl::View() const { 117 WebView* WebRemoteFrameImpl::View() const {
128 if (!GetFrame()) { 118 if (!GetFrame()) {
129 return nullptr; 119 return nullptr;
130 } 120 }
131 DCHECK(GetFrame()->GetPage()); 121 DCHECK(GetFrame()->GetPage());
132 return GetFrame()->GetPage()->GetChromeClient().GetWebView(); 122 return GetFrame()->GetPage()->GetChromeClient().GetWebView();
133 } 123 }
134 124
135 WebDocument WebRemoteFrameImpl::GetDocument() const { 125 WebDocument WebRemoteFrameImpl::GetDocument() const {
136 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of 126 // TODO(dcheng): this should also ASSERT_NOT_REACHED, but a lot of
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 } 386 }
397 387
398 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, 388 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
399 WebRemoteFrameClient* client) 389 WebRemoteFrameClient* client)
400 : WebRemoteFrameBase(scope), 390 : WebRemoteFrameBase(scope),
401 frame_client_(RemoteFrameClientImpl::Create(this)), 391 frame_client_(RemoteFrameClientImpl::Create(this)),
402 client_(client), 392 client_(client),
403 self_keep_alive_(this) {} 393 self_keep_alive_(this) {}
404 394
405 } // namespace blink 395 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698