Elim x86-generic from chromium.chromiumos waterfall

Elim x86-generic from chromium.chromiumos waterfall

BUG=735278
Review-Url: https://codereview.chromium.org/2952773002
Cr-Commit-Position: refs/heads/master@{#481429}
Committed: https://chromium.googlesource.com/chromium/src/+/4b2aa9627becb3d376aad991c3eb7969c5d070d9

[stevenjb, 2017-06-21 00:25:54]

stevenjb@chromium.org changed reviewers:
+ achuith@chromium.org, dpranke@chromium.org, ihf@chromium.org

[Dirk Pranke, 2017-06-21 00:46:30]

https://codereview.chromium.org/2952773002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (left):

https://codereview.chromium.org/2952773002/diff/1/tools/mb/mb_config.pyl#oldc...
tools/mb/mb_config.pyl:91: 'ChromiumOS x86-generic Compile': 'cros_chrome_sdk',
There is also the chromeos_x86-generic_chromium_compile_only_ng bot on
tryserver.chromium.linux .

Also, we should remove the builders before we actually land this change;
otherwise the builds will start to fail.

[stevenjb, 2017-06-21 19:48:39]

https://codereview.chromium.org/2952773002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (left):

https://codereview.chromium.org/2952773002/diff/1/tools/mb/mb_config.pyl#oldc...
tools/mb/mb_config.pyl:91: 'ChromiumOS x86-generic Compile': 'cros_chrome_sdk',
On 2017/06/21 00:46:30, Dirk Pranke wrote:
> There is also the chromeos_x86-generic_chromium_compile_only_ng bot on
> tryserver.chromium.linux .
> 
Ah, thanks, removed.

> Also, we should remove the builders before we actually land this change;
> otherwise the builds will start to fail.

Could you clarify "remove the builders"? What builds would start to fail?
Thanks!

[Dirk Pranke, 2017-06-21 20:27:24]

On 2017/06/21 19:48:39, stevenjb wrote:
> > Also, we should remove the builders before we actually land this change;
> > otherwise the builds will start to fail.
> 
> Could you clarify "remove the builders"? What builds would start to fail?
> Thanks!

We need to actually remove the builders from the buildbot configurations so that
they don't show up on the waterfalls anymore. If you land this change before we
do that, when the builder runs it'll attempt to generate the appropriate ninja
files and fail, failing the build.

Removing the builders is easy; I'll upload a CL for that shortly.

[stevenjb, 2017-06-21 20:31:12]

On 2017/06/21 20:27:24, Dirk Pranke wrote:
> On 2017/06/21 19:48:39, stevenjb wrote:
> > > Also, we should remove the builders before we actually land this change;
> > > otherwise the builds will start to fail.
> > 
> > Could you clarify "remove the builders"? What builds would start to fail?
> > Thanks!
> 
> We need to actually remove the builders from the buildbot configurations so
that
> they don't show up on the waterfalls anymore. If you land this change before
we
> do that, when the builder runs it'll attempt to generate the appropriate ninja
> files and fail, failing the build.
> 
> Removing the builders is easy; I'll upload a CL for that shortly.

OK, thanks!

[Dirk Pranke, 2017-06-22 01:37:59]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2017-06-22 01:38:09]

builders remove, this lgtm.

[commit-bot: I haz the power, 2017-06-22 01:38:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-06-22 01:38:22]

On 2017/06/22 01:38:09, Dirk Pranke wrote:
> builders remove, this lgtm.

sheesh, builders "removed".

[commit-bot: I haz the power, 2017-06-22 03:48:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498095479831500,
"parent_rev": "d7cb3169b3a67b6089cd1a8bdd2e1b08231a0cb4", "commit_rev":
"4b2aa9627becb3d376aad991c3eb7969c5d070d9"}

[commit-bot: I haz the power, 2017-06-22 03:48:39]

Description was changed from

==========
Elim x86-generic from chromium.chromiumos waterfall

BUG=735278
==========

to

==========
Elim x86-generic from chromium.chromiumos waterfall

BUG=735278

Review-Url: https://codereview.chromium.org/2952773002
Cr-Commit-Position: refs/heads/master@{#481429}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b2aa9627becb3d376aad991c3eb...
==========

[commit-bot: I haz the power, 2017-06-22 03:48:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b2aa9627becb3d376aad991c3eb...