Add SurfaceWillDraw notification

Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as 
surfaces are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2938833002
Cr-Commit-Position: refs/heads/master@{#479865}
Committed: https://chromium.googlesource.com/chromium/src/+/a15e976b52b92c65ad791be142dbd5f11364ae07

[gklassen, 2017-06-14 13:45:25]

Description was changed from

==========
SurfaceWillDraw notification
to allow hit-test component to monitor which surfaces were selected
for the current display frame

BUG=732398
==========

to

==========
SurfaceWillDraw notification
to allow hit-test component to monitor which surfaces were selected
for the current display frame

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 13:48:41]

Description was changed from

==========
SurfaceWillDraw notification
to allow hit-test component to monitor which surfaces were selected
for the current display frame

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
SurfaceWillDraw notification
to allow hit-test component to monitor which surfaces were selected
for the current display frame

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 13:48:41]

gklassen@chromium.org changed reviewers:
+ fsamuel@google.com, rjkroege@chromium.org

[rjkroege, 2017-06-14 13:59:12]

Please write a longer CL description.

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
File components/viz/frame_sinks/mojo_frame_sink_manager.cc (right):

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
components/viz/frame_sinks/mojo_frame_sink_manager.cc:150: void
OnSurfaceWillDraw(const cc::SurfaceId& surface_id) {}
why is this not in MojoFrameSinkManager::?

[rjkroege, 2017-06-14 14:00:29]

On 2017/06/14 13:59:12, rjkroege wrote:
> Please write a longer CL description.

https://chromium-review.googlesource.com/506430 is a good example of both
formatting and detail.

> 
>
https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
> File components/viz/frame_sinks/mojo_frame_sink_manager.cc (right):
> 
>
https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
> components/viz/frame_sinks/mojo_frame_sink_manager.cc:150: void
> OnSurfaceWillDraw(const cc::SurfaceId& surface_id) {}
> why is this not in MojoFrameSinkManager::?

[gklassen, 2017-06-14 15:08:00]

Description was changed from

==========
SurfaceWillDraw notification
to allow hit-test component to monitor which surfaces were selected
for the current display frame

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Adds a SurfaceWillDraw notification to SurfaceObserver to all the viz hit-test
component to monitor which surfaces were selected for the current display frame.

Viz will implement a hit-test component that will aggregate hit-test information
published along with compositor frames.  The aggregated data will be made
available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current information
for the frame it needs to know which surfaces have been added to the current
DisplayFrame.  

A method has been added to Surface observer so that observers will be notified
as surfaces are added to the Display frame.  The notification is invoked during
Surface Aggregation at the same place and following the same convention as the
existing RunWillDrawCallback - the key difference being that this implementation
allows one observer to monitor all surfaces without creating observers for each
surface instance.  




BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-06-14 15:15:25]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-06-14 15:15:26]

Generally looks good except the comment Rob made.

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
File components/viz/frame_sinks/mojo_frame_sink_manager.cc (right):

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
components/viz/frame_sinks/mojo_frame_sink_manager.cc:150: void
OnSurfaceWillDraw(const cc::SurfaceId& surface_id) {}
On 2017/06/14 13:59:12, rjkroege wrote:
> why is this not in MojoFrameSinkManager::?

Yea, I'm kind of surprised this compiles?

[gklassen, 2017-06-14 15:16:35]

MojoFrameSinkManager::OnSurfaceWillDraw impl corrected.

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
File components/viz/frame_sinks/mojo_frame_sink_manager.cc (right):

https://codereview.chromium.org/2938833002/diff/1/components/viz/frame_sinks/...
components/viz/frame_sinks/mojo_frame_sink_manager.cc:150: void
OnSurfaceWillDraw(const cc::SurfaceId& surface_id) {}
On 2017/06/14 13:59:12, rjkroege wrote:
> why is this not in MojoFrameSinkManager::?

Done.

[Fady Samuel, 2017-06-14 15:24:25]

Description was changed from

==========
Adds a SurfaceWillDraw notification to SurfaceObserver to all the viz hit-test
component to monitor which surfaces were selected for the current display frame.

Viz will implement a hit-test component that will aggregate hit-test information
published along with compositor frames.  The aggregated data will be made
available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current information
for the frame it needs to know which surfaces have been added to the current
DisplayFrame.  

A method has been added to Surface observer so that observers will be notified
as surfaces are added to the Display frame.  The notification is invoked during
Surface Aggregation at the same place and following the same convention as the
existing RunWillDrawCallback - the key difference being that this implementation
allows one observer to monitor all surfaces without creating observers for each
surface instance.  




BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Adds a SurfaceWillDraw notification to SurfaceObserver to all the viz 
hit-test component to monitor which surfaces were selected for the 
current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-06-14 15:24:48]

lgtm

[rjkroege, 2017-06-14 15:26:38]

On 2017/06/14 15:24:48, Fady Samuel wrote:
> lgtm

lgtm

[rjkroege, 2017-06-14 15:27:24]

On 2017/06/14 15:26:38, rjkroege wrote:
> On 2017/06/14 15:24:48, Fady Samuel wrote:
> > lgtm
> 
> lgtm

nit: weird sentence in description.

[gklassen, 2017-06-14 15:27:51]

Description was changed from

==========
Adds a SurfaceWillDraw notification to SurfaceObserver to all the viz 
hit-test component to monitor which surfaces were selected for the 
current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Adds a SurfaceWillDraw notification to monitor which surfaces were selected for
the current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 15:28:05]

Description was changed from

==========
Adds a SurfaceWillDraw notification to monitor which surfaces were selected for
the current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Adds a SurfaceWillDraw notification to monitor which surfaces were 
selected for the current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 15:28:35]

gklassen@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-06-14 18:10:57]

(Unlike gerrit, rietveld does not send a message when you add a reviewer, you
need to publish to let them know, I was looking because you had sent another
email so I saw I'm added here)

[danakj, 2017-06-14 18:13:12]

> Adds a SurfaceWillDraw notification to monitor which surfaces were 
> selected for the current display frame.


The first line of a git commit message needs to be exactly one line. It ends at
a line break. This is a good explanation of git commit messages if you're
unfamiliar: https://chris.beams.io/posts/git-commit/

[gklassen, 2017-06-14 18:33:44]

Description was changed from

==========
Adds a SurfaceWillDraw notification to monitor which surfaces were 
selected for the current display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as surfaces
are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 18:36:36]

Description was changed from

==========
Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as surfaces
are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as 
surfaces are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[gklassen, 2017-06-14 18:43:01]

Thank you for the comments - the description is now updated.

[danakj, 2017-06-14 18:53:12]

Seems good overall. It might make sense to look at splitting up SurfaceObserver
at some point, to avoid so many empty implementations, but not sure the time is
now.

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:767:
manager_->SurfaceWillDraw(surface->surface_id());
Would it be better to collect a set of surface ids and give them all in a single
callback? Would that let the consumer do smarter things? Will each user of the
callback have to do to the same otherwise?

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_man...
File cc/surfaces/surface_manager.h (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.h:77: // Called when a surface has been added to the
Display Frame and will
Display Frame is written like it is a type, but I don't think it is. You're
referring to the aggregated CompositorFrame in the Display, I believe.

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_obs...
File cc/surfaces/surface_observer.h (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_obs...
cc/surfaces/surface_observer.h:41: // Runs when SurfaceAggregator has added the
surface to the Display Frame.
same here re Display Frame, this is about SurfaceAggregator including the
Surface in what is going to be drawn (which is represented as a CompositorFrame
right now, tho may not always)

[gklassen, 2017-06-14 19:29:11]

Thank you for the comments Dana ( and the help understanding how the review tool
works :).  

I have updated the comments based on your feedback and they seem clearer - Thank
you. 

Thank you also for the suggestion of sending the list of surfaces in a single
callback - the currently contemplated consumer seems like it would have limited
ability to do something smarter with a list, but perhaps we can revisit if and
when we add other observers?

Sound ok?

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:767:
manager_->SurfaceWillDraw(surface->surface_id());
On 2017/06/14 18:53:12, danakj wrote:
> Would it be better to collect a set of surface ids and give them all in a
single
> callback? Would that let the consumer do smarter things? Will each user of the
> callback have to do to the same otherwise?

In the consumer we are currently contemplating it needs to do the same work for
each surface ( move the associated hit test data to an active list ) - so it
doesn't seem like it would provide much immediate benefit but we may want to
revisit later and if we add other consumers.

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_man...
File cc/surfaces/surface_manager.h (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.h:77: // Called when a surface has been added to the
Display Frame and will
On 2017/06/14 18:53:12, danakj wrote:
> Display Frame is written like it is a type, but I don't think it is. You're
> referring to the aggregated CompositorFrame in the Display, I believe.

Good call.  Your suggestion makes the description clearer.  Thank you. 
 
Done.

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_obs...
File cc/surfaces/surface_observer.h (right):

https://codereview.chromium.org/2938833002/diff/20001/cc/surfaces/surface_obs...
cc/surfaces/surface_observer.h:41: // Runs when SurfaceAggregator has added the
surface to the Display Frame.
On 2017/06/14 18:53:12, danakj wrote:
> same here re Display Frame, this is about SurfaceAggregator including the
> Surface in what is going to be drawn (which is represented as a
CompositorFrame
> right now, tho may not always)

Agreed.  Comment updated. 

Done.

[gklassen, 2017-06-15 18:47:30]

The CQ bit was checked by gklassen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 18:48:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 18:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:51:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gklassen, 2017-06-15 19:02:33]

The CQ bit was checked by gklassen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 19:03:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-06-15 19:51:21]

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:767:
manager_->SurfaceWillDraw(surface->surface_id());
Just realized there's no test that this is happening, which means it could
regress in the future. Can you add a test to show this is called for aggregated
surfaces, and not for ones that are skipped? LGTM with a test

[gklassen, 2017-06-15 20:00:21]

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:767:
manager_->SurfaceWillDraw(surface->surface_id());
On 2017/06/15 19:51:20, danakj wrote:
> Just realized there's no test that this is happening, which means it could
> regress in the future. Can you add a test to show this is called for
aggregated
> surfaces, and not for ones that are skipped? LGTM with a test

Good call, Thank you. Test coming soon...

[commit-bot: I haz the power, 2017-06-15 20:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 20:16:18]

Dry run: This issue passed the CQ dry run.

[gklassen, 2017-06-15 21:07:58]

With help from Fady I have added unit tests to verify that OnSurfaceWillDraw is
called for surfaces added to the CompositorFrame ( and only surfaces added to
the CompositorFrame ). 

Please let me know if this looks ok.

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/2938833002/diff/60001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:767:
manager_->SurfaceWillDraw(surface->surface_id());
On 2017/06/15 20:00:21, gklassen wrote:
> On 2017/06/15 19:51:20, danakj wrote:
> > Just realized there's no test that this is happening, which means it could
> > regress in the future. Can you add a test to show this is called for
> aggregated
> > surfaces, and not for ones that are skipped? LGTM with a test
> 
> Good call, Thank you. Test coming soon... 

Done.

[fsamuel, 2017-06-15 21:11:34]

lgtm

[danakj, 2017-06-15 21:12:33]

Thanks! LGTM

[gklassen, 2017-06-15 21:13:26]

The CQ bit was checked by gklassen@chromium.org

[gklassen, 2017-06-15 21:13:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2938833002/#ps120001
(title: "add unit test to verify that OnSurfaceWillDraw is called only for
surfaces added to the CompositorF…")

[commit-bot: I haz the power, 2017-06-15 21:14:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 22:22:43]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497561206112450,
"parent_rev": "db6d7fe9267ec2297918e2589558f0a46d1f7039", "commit_rev":
"b09904a0fea1e2b60e2fe12d651c269319763f84"}

[commit-bot: I haz the power, 2017-06-15 22:23:03]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497561206112450,
"parent_rev": "a18f38c607db22eed956aff833f70ad246bc6ea6", "commit_rev":
"a15e976b52b92c65ad791be142dbd5f11364ae07"}

[commit-bot: I haz the power, 2017-06-15 22:23:17]

Description was changed from

==========
Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as 
surfaces are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add SurfaceWillDraw notification

Adds a SurfaceWillDraw notification to allow observers to monitor as 
surfaces are added to the next display frame.

Viz will implement a hit-test component that will aggregate hit-test 
information published along with compositor frames.  The aggregated 
data will be made available for hit testing in a shared memory object. 

In order to ensure that the hit-test information matches the current 
information for the frame it needs to know which surfaces have been 
added to the current DisplayFrame.  

A method has been added to Surface observer so that observers will be 
notified as surfaces are added to the Display frame.  The notification 
is invoked during Surface Aggregation at the same place and following 
the same convention as the existing RunWillDrawCallback - the key 
difference being that this implementation allows one observer to 
monitor all surfaces without creating observers for each surface 
instance.  

BUG=732398
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2938833002
Cr-Commit-Position: refs/heads/master@{#479865}
Committed:
https://chromium.googlesource.com/chromium/src/+/a15e976b52b92c65ad791be142db...
==========

[commit-bot: I haz the power, 2017-06-15 22:23:18]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a15e976b52b92c65ad791be142db...