Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2938823003: Move WriteJSONFile to its sole caller's package, with some refactoring. (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Move WriteJSONFile to its sole caller's package, with some refactoring. BUG=732677 Review-Url: https://codereview.chromium.org/2938823003 Committed: https://github.com/luci/luci-go/commit/3b2cf368c09e435c41d69235e93ff7eb5980bd5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M client/cmd/isolate/batch_archive.go View 2 chunks +27 lines, -1 line 0 comments Download
D client/internal/common/json.go View 1 chunk +0 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 6 months ago (2017-06-15 05:09:41 UTC) #2
mithro
lgtm
3 years, 6 months ago (2017-06-15 05:16:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938823003/1
3 years, 6 months ago (2017-06-15 05:19:56 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 05:30:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/3b2cf368c09e435c41d69235e93ff7eb5980bd5b

Powered by Google App Engine
This is Rietveld 408576698