Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2933273002: Remove ReadJSONFile (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Remove ReadJSONFile Also some refactoring in batcharchive. BUG=732677 Review-Url: https://codereview.chromium.org/2933273002 Committed: https://github.com/luci/luci-go/commit/a4a9617ec3dc88d18d92653b0270f584fcbcc98e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M client/cmd/isolate/batch_archive.go View 2 chunks +23 lines, -5 lines 0 comments Download
M client/internal/common/json.go View 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 6 months ago (2017-06-13 06:38:24 UTC) #2
mithro
lgtm
3 years, 6 months ago (2017-06-13 06:55:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933273002/1
3 years, 6 months ago (2017-06-15 04:14:30 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 04:20:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/a4a9617ec3dc88d18d92653b0270f584fcbcc98e

Powered by Google App Engine
This is Rietveld 408576698