Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2938743002: Revert of Text change on 'Browse as Guest' button (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, rkc, srahim
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Text change on 'Browse as Guest' button (patchset #3 id:40001 of https://codereview.chromium.org/2864793002/ ) Reason for revert: According to UI-reivew, 'Guest' should be capitalized because it's treated as a stand in for a user name (e.g. in the status tray) since it's a special mode. Original issue's description: > Text change on 'Browse as Guest' button > > BUG=715637 > > Review-Url: https://codereview.chromium.org/2864793002 > Cr-Commit-Position: refs/heads/master@{#470871} > Committed: https://chromium.googlesource.com/chromium/src/+/a5c71ee3a3a1a08041849f51f7e457e9673014f1 TBR=jcivelli@chromium.org,alemate@chromium.org,msarda@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=715637 Review-Url: https://codereview.chromium.org/2938743002 Cr-Commit-Position: refs/heads/master@{#479860} Committed: https://chromium.googlesource.com/chromium/src/+/a89cf93013a528e4627bc5d6d06b5889ea4e845d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Wenzhao (Colin) Zang
Created Revert of Text change on 'Browse as Guest' button
3 years, 6 months ago (2017-06-14 00:23:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938743002/1
3 years, 6 months ago (2017-06-14 00:23:40 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-14 00:23:42 UTC) #5
Wenzhao (Colin) Zang
PTAL, thanks so much. Please disregard the last email.
3 years, 6 months ago (2017-06-14 00:29:20 UTC) #6
msarda
LGTM with a nit. Please fix before landing the CL. https://codereview.chromium.org/2938743002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2938743002/diff/1/chrome/app/generated_resources.grd#newcode10925 ...
3 years, 6 months ago (2017-06-14 07:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938743002/90001
3 years, 6 months ago (2017-06-15 22:10:21 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 22:15:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/a89cf93013a528e4627bc5d6d06b...

Powered by Google App Engine
This is Rietveld 408576698