Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2864793002:
Text change on 'Browse as Guest' button (Closed)
|
Created:
3 years, 7 months ago by Wenzhao (Colin) Zang Modified:
3 years, 6 months ago CC:
chromium-reviews, srahim+watch_chromium.org, rkc, srahim Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionText change on 'Browse as Guest' button
BUG=715637
Review-Url: https://codereview.chromium.org/2864793002
Cr-Commit-Position: refs/heads/master@{#470871}
Committed: https://chromium.googlesource.com/chromium/src/+/a5c71ee3a3a1a08041849f51f7e457e9673014f1
Patch Set 1 #
Total comments: 1
Patch Set 2 : Change the IDS name #Patch Set 3 : Change the IDS name #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== Text change on 'Browse as Guest' button BUG=715637 ========== to ========== Text change on 'Browse as Guest' button BUG=715637 ==========
wzang@chromium.org changed reviewers: + alemate@google.com, jcivelli@chromium.org
wzang@chromium.org changed reviewers: + alemate@chromium.org, jcivelli@chromium.org - alemate@google.com, jcivelli@chromium.org
alemate@chromium.org changed reviewers: + mahmadi@chromium.org
+mahmadi This is a shared string (this is also used in md_user_manager). Mohamad, please review. lgtm from ChromeOS side. (but we can also take another approach if desktop cannot update this string)
mahmadi@chromium.org changed reviewers: + msarda@chromium.org
mahmadi@chromium.org changed reviewers: - mahmadi@chromium.org
On 2017/05/08 13:15:40, Moe wrote: +Shimi I think we want to continue capitalizing "Guest" on desktop. However, in the user manager, we use an all caps font (https://drive.google.com/open?id=0Byv8caX1Ib9dRGY2c0Y2aG1kbDg). So if that is the only place this string is used, then changing to a lowercase "g" shouldn't affect it, right?
Concerning upper caps question: * The button is a secondary paper button defined here: https://cs.chromium.org/chromium/src/chrome/browser/resources/md_user_manager... I think the style for this kind of button is to be upper caps. LGTM with a suggestion. https://codereview.chromium.org/2864793002/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2864793002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:10925: <message name="IDS_GO_INCOGNITO_BUTTON" desc="Text shown on Chrome OS sign-in screen button that launches guest session. Should be short."> While you are here, please also change the name of this IDS as this is not really go incognito. Please change this to IDS_BROWSE_AS_GUEST_BUTTON.
The CQ bit was checked by wzang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2864793002/#ps40001 (title: "Change the IDS name")
On 2017/05/09 11:15:55, msarda wrote: > Concerning upper caps question: > * The button is a secondary paper button defined here: > https://cs.chromium.org/chromium/src/chrome/browser/resources/md_user_manager... > > I think the style for this kind of button is to be upper caps. > > LGTM with a suggestion. > > https://codereview.chromium.org/2864793002/diff/1/chrome/app/generated_resour... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2864793002/diff/1/chrome/app/generated_resour... > chrome/app/generated_resources.grd:10925: <message > name="IDS_GO_INCOGNITO_BUTTON" desc="Text shown on Chrome OS sign-in screen > button that launches guest session. Should be short."> > While you are here, please also change the name of this IDS as this is not > really go incognito. Please change this to IDS_BROWSE_AS_GUEST_BUTTON. Done. Thanks.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494484063593600,
"parent_rev": "fa3fdf20cea4dbedd74476a40649e708ab1827a0", "commit_rev":
"a5c71ee3a3a1a08041849f51f7e457e9673014f1"}
Message was sent while issue was closed.
Description was changed from ========== Text change on 'Browse as Guest' button BUG=715637 ========== to ========== Text change on 'Browse as Guest' button BUG=715637 Review-Url: https://codereview.chromium.org/2864793002 Cr-Commit-Position: refs/heads/master@{#470871} Committed: https://chromium.googlesource.com/chromium/src/+/a5c71ee3a3a1a08041849f51f7e4... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a5c71ee3a3a1a08041849f51f7e4...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2938743002/ by wzang@chromium.org. The reason for reverting is: According to UI-reivew, the request for caps on 'Guest' is because it's treated sort of as a stand in for a user name (e.g. in the status tray) since it's a special mode..
Message was sent while issue was closed.
PTAL, thanks so much. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
