Refactor make_computed_style_base.py Field class to link to a Group.

Refactor make_computed_style_base.py Field class to link to a Group.

In make_computed_style_base.py:
- A field should know what Group it's in.
- A group should know what fields it has.

However, there is a circular dependency here. Previously, this has
been resolved by storing duplicate Group information in Field, so that
we can retrieve the necessary group information from Field, but not the
actual Group instance.

As we store more information on Groups, more duplicate information need
to be stored in Field, which makes this current solution ugly. A better
approach would be to store a reference to the actual Group instance in
Field.

This patch makes it so that when we create a Group with a set of fields,
we link the corresponding fields back to the Group.

This patch doesn't change behaviour nor generated code.

BUG=628043
Review-Url: https://codereview.chromium.org/2938553002
Cr-Commit-Position: refs/heads/master@{#478920}
Committed: https://chromium.googlesource.com/chromium/src/+/f88c5b041d56422d91ee46d144833efa3d152f42

[shend, 2017-06-13 00:14:20]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:15:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-06-13 00:16:54]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-06-13 00:16:54]

Hi Naina, PTAL. Sorry for the bad CL description, I think reading the code would
be clearer.

[commit-bot: I haz the power, 2017-06-13 00:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:18:35]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-06-13 00:37:57]

Description was changed from

==========
Refactor make_computed_style_base.py Field class to link to a Group.

In make_computed_style_base.py:
- A field should know what Group it's in.
- A group should know what fields it has.

However, there is a circular dependency here. Previously, this has
been resolved by storing duplicate Group information in Field, so that
we can retrieve the necessary group information from Field, but not the
actual Group instance.

As we store more information on Groups, more duplicate information need
to be stored in Field, which makes this current solution ugly. A better
approach would be to store a reference to the actual Group instance in
Field.

This patch makes it so that when we create a Group with a set of fields,
we link the corresponding fields back to the Group.

BUG=628043
==========

to

==========
Refactor make_computed_style_base.py Field class to link to a Group.

In make_computed_style_base.py:
- A field should know what Group it's in.
- A group should know what fields it has.

However, there is a circular dependency here. Previously, this has
been resolved by storing duplicate Group information in Field, so that
we can retrieve the necessary group information from Field, but not the
actual Group instance.

As we store more information on Groups, more duplicate information need
to be stored in Field, which makes this current solution ugly. A better
approach would be to store a reference to the actual Group instance in
Field.

This patch makes it so that when we create a Group with a set of fields,
we link the corresponding fields back to the Group.

This patch doesn't change behaviour nor generated code.

BUG=628043
==========

[shend, 2017-06-13 00:39:43]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:40:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 03:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 03:04:27]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-06-13 07:11:32]

lgtm

[shend, 2017-06-13 07:13:01]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-06-13 07:13:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 07:17:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497337981884900,
"parent_rev": "e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72", "commit_rev":
"f88c5b041d56422d91ee46d144833efa3d152f42"}

[commit-bot: I haz the power, 2017-06-13 07:17:22]

Description was changed from

==========
Refactor make_computed_style_base.py Field class to link to a Group.

In make_computed_style_base.py:
- A field should know what Group it's in.
- A group should know what fields it has.

However, there is a circular dependency here. Previously, this has
been resolved by storing duplicate Group information in Field, so that
we can retrieve the necessary group information from Field, but not the
actual Group instance.

As we store more information on Groups, more duplicate information need
to be stored in Field, which makes this current solution ugly. A better
approach would be to store a reference to the actual Group instance in
Field.

This patch makes it so that when we create a Group with a set of fields,
we link the corresponding fields back to the Group.

This patch doesn't change behaviour nor generated code.

BUG=628043
==========

to

==========
Refactor make_computed_style_base.py Field class to link to a Group.

In make_computed_style_base.py:
- A field should know what Group it's in.
- A group should know what fields it has.

However, there is a circular dependency here. Previously, this has
been resolved by storing duplicate Group information in Field, so that
we can retrieve the necessary group information from Field, but not the
actual Group instance.

As we store more information on Groups, more duplicate information need
to be stored in Field, which makes this current solution ugly. A better
approach would be to store a reference to the actual Group instance in
Field.

This patch makes it so that when we create a Group with a set of fields,
we link the corresponding fields back to the Group.

This patch doesn't change behaviour nor generated code.

BUG=628043

Review-Url: https://codereview.chromium.org/2938553002
Cr-Commit-Position: refs/heads/master@{#478920}
Committed:
https://chromium.googlesource.com/chromium/src/+/f88c5b041d56422d91ee46d14483...
==========

[commit-bot: I haz the power, 2017-06-13 07:17:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f88c5b041d56422d91ee46d14483...