third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl - Issue 2938553002: Refactor make_computed_style_base.py Field class to link to a Group.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2938553002: Refactor make_computed_style_base.py Field class to link to a Group. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

index 08600f1ba6ad506735d3a56c41683a5bcb1a920e..60e54f25f62c3a0ab7028c3147f736a612f30f3e 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

@@ -6,7 +6,7 @@

void {{field.setter_method_name}}({{field.type_name}}&& v) {

-{% if field.group_member_name %}

+{% if field.group %}

if (!({{getter_expression(field)}} == v))

{{setter_expression(field)}} = std::move(v);

{% else %}