Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2938483002: [MD settings] use regex to replace all nbsp (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Original-Commit-Position: refs/heads/master@{#478368} Review-Url: https://codereview.chromium.org/2938483002 . Cr-Commit-Position: refs/branch-heads/3112@{#310} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/data/webui/i18n_behavior_test.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dschuyler
3 years, 6 months ago (2017-06-12 18:53:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4cfc0b7dcf48f68fcc5df65fc79d5f25955428b6.

Powered by Google App Engine
This is Rietveld 408576698