Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2930833004: [MD settings] use regex replace all nbsp (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. Related bug: 731289 BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616cab2211f1a301f

Patch Set 1 #

Patch Set 2 : improved unit test #

Patch Set 3 : review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/data/webui/i18n_behavior_test.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (19 generated)
dschuyler
3 years, 6 months ago (2017-06-09 00:57:15 UTC) #7
dschuyler
From in-person review.
3 years, 6 months ago (2017-06-09 01:22:05 UTC) #10
dpapad
LGTM
3 years, 6 months ago (2017-06-09 01:26:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930833004/40001
3 years, 6 months ago (2017-06-09 19:17:20 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 19:23:30 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca...

Powered by Google App Engine
This is Rietveld 408576698