|
|
Chromium Code Reviews
Description[MD settings] use regex to replace all nbsp
This CL allows for the unicode non-breaking space '\u00a0' to appear in
translations. This is an improvement (replacement) on CL 2926573003
which only replace the first occurrence. This CL will replace all of the
nbsp in the string.
Related bug: 731289
BUG=730025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2930833004
Cr-Commit-Position: refs/heads/master@{#478368}
Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616cab2211f1a301f
Patch Set 1 #Patch Set 2 : improved unit test #Patch Set 3 : review changes #
Messages
Total messages: 24 (19 generated)
Description was changed from ========== [MD settings] use split.join to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025 ========== to ========== [MD settings] use split.join to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
From in-person review.
LGTM
Description was changed from ========== [MD settings] use split.join to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. (Related to bug 730025) BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. (Related to bug 730025) BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497035814517580,
"parent_rev": "832c0a2f3b0f11b51c6509302b365269c2f815a0", "commit_rev":
"1fc3b248c69ca7c5d02ee21616cab2211f1a301f"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca...
Message was sent while issue was closed.
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=730025, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca... ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=731289, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca... ==========
Message was sent while issue was closed.
Description was changed from ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. BUG=731289, 730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca... ========== to ========== [MD settings] use regex to replace all nbsp This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. This is an improvement (replacement) on CL 2926573003 which only replace the first occurrence. This CL will replace all of the nbsp in the string. Related bug: 731289 BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930833004 Cr-Commit-Position: refs/heads/master@{#478368} Committed: https://chromium.googlesource.com/chromium/src/+/1fc3b248c69ca7c5d02ee21616ca... ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
