Issue 2938473002: [MD settings] allow unicode nbsp in i18n behavior strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2938473002: [MD settings] allow unicode nbsp in i18n behavior strings (Closed)

Created:
3 years, 6 months ago by dschuyler

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

[MD settings] allow unicode nbsp in i18n behavior strings This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. Such spaces appear in the French translation file 1600+ times, for example. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2926573003 Cr-Original-Commit-Position: refs/heads/master@{#477729} Review-Url: https://codereview.chromium.org/2938473002 . Cr-Commit-Position: refs/branch-heads/3112@{#309} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/109c6b4f90c73295d76fb18354c261cdf6c1250e

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	chrome/test/data/webui/i18n_behavior_test.html	View		2 chunks	+13 lines, -5 lines	0 comments	Download
	M	ui/webui/resources/js/i18n_behavior.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dschuyler

3 years, 6 months ago (2017-06-12 18:51:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
109c6b4f90c73295d76fb18354c261cdf6c1250e.