Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2926573003: [MD settings] allow unicode nbsp in i18n behavior strings (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] allow unicode nbsp in i18n behavior strings This CL allows for the unicode non-breaking space '\u00a0' to appear in translations. Such spaces appear in the French translation file 1600+ times, for example. BUG=730025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2926573003 Cr-Commit-Position: refs/heads/master@{#477729} Committed: https://chromium.googlesource.com/chromium/src/+/e5aa99d9d101379b1542958a71df3f50913f1ea2

Patch Set 1 : var name change #

Patch Set 2 : reduced comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/test/data/webui/i18n_behavior_test.html View 2 chunks +13 lines, -6 lines 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
dschuyler
3 years, 6 months ago (2017-06-07 01:09:35 UTC) #10
Dan Beam
lgtm
3 years, 6 months ago (2017-06-07 01:11:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926573003/40001
3 years, 6 months ago (2017-06-07 19:35:18 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 19:42:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5aa99d9d101379b1542958a71df...

Powered by Google App Engine
This is Rietveld 408576698