Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2938383003: Added basic 'I want to help improve performance' doc (Closed)

Created:
3 years, 6 months ago by sullivan
Modified:
3 years, 6 months ago
Reviewers:
benry, benhenry
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added basic 'I want to help improve performance' doc TBR=simonhatch@chromium.org Review-Url: https://codereview.chromium.org/2938383003 Cr-Commit-Position: refs/heads/master@{#480206} Committed: https://chromium.googlesource.com/chromium/src/+/7c3d1e278d0aef75ca64cb5778ff3b923acb626b

Patch Set 1 #

Total comments: 2

Patch Set 2 : clarify trace on tap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A docs/speed/help_improve_performance.md View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sullivan
In contrast to yesterday's long docs, this is an attempt to add a minimal amount ...
3 years, 6 months ago (2017-06-16 19:16:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938383003/1
3 years, 6 months ago (2017-06-16 19:34:23 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-16 19:34:24 UTC) #6
benhenry
https://codereview.chromium.org/2938383003/diff/1/docs/speed/help_improve_performance.md File docs/speed/help_improve_performance.md (right): https://codereview.chromium.org/2938383003/diff/1/docs/speed/help_improve_performance.md#newcode10 docs/speed/help_improve_performance.md:10: * **(For Googlers) try TraceOnTap** the [TraceOnTap Extension](http://goto.google.com/traceontap) This ...
3 years, 6 months ago (2017-06-16 22:01:25 UTC) #8
sullivan
https://codereview.chromium.org/2938383003/diff/1/docs/speed/help_improve_performance.md File docs/speed/help_improve_performance.md (right): https://codereview.chromium.org/2938383003/diff/1/docs/speed/help_improve_performance.md#newcode10 docs/speed/help_improve_performance.md:10: * **(For Googlers) try TraceOnTap** the [TraceOnTap Extension](http://goto.google.com/traceontap) On ...
3 years, 6 months ago (2017-06-16 22:34:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938383003/20001
3 years, 6 months ago (2017-06-16 22:35:24 UTC) #12
benhenry
lgtm
3 years, 6 months ago (2017-06-16 22:47:43 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 22:51:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c3d1e278d0aef75ca64cb5778ff...

Powered by Google App Engine
This is Rietveld 408576698