Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2938313002: Don't show current RenderWidgetHostView while interstitial is showing. (Closed)
Patch Set: Fix typo. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 42c7e04c9958270c688f4ee3c21fa1f3d30b1e99..85e400eaf399da2c9b8cf27d13baf99d6f3c8faa 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -61,7 +61,6 @@ RenderFrameHostManager::RenderFrameHostManager(
delegate_(delegate),
render_frame_delegate_(render_frame_delegate),
render_widget_delegate_(render_widget_delegate),
- interstitial_page_(nullptr),
weak_factory_(this) {
DCHECK(frame_tree_node_);
}
@@ -133,8 +132,8 @@ WebUIImpl* RenderFrameHostManager::GetNavigatingWebUI() const {
}
RenderWidgetHostView* RenderFrameHostManager::GetRenderWidgetHostView() const {
- if (interstitial_page_)
- return interstitial_page_->GetView();
+ if (delegate_->GetInterstitialForRenderManager())
+ return delegate_->GetInterstitialForRenderManager()->GetView();
if (render_frame_host_)
return render_frame_host_->GetView();
return nullptr;
@@ -1438,7 +1437,7 @@ RenderFrameHostManager::DetermineSiteInstanceForURL(
// SiteInstances if you type in a cross-site URL. This means we have to
// compare the entry's URL to the last committed entry's URL.
NavigationEntry* current_entry = controller.GetLastCommittedEntry();
- if (interstitial_page_) {
+ if (delegate_->GetInterstitialForRenderManager()) {
// The interstitial is currently the last committed entry, but we want to
// compare against the last non-interstitial entry.
current_entry = controller.GetEntryAtOffset(-1);
@@ -2864,13 +2863,13 @@ bool RenderFrameHostManager::CanSubframeSwapProcess(
}
void RenderFrameHostManager::EnsureRenderFrameHostVisibilityConsistent() {
- if (render_frame_host_->GetView() &&
- render_frame_host_->render_view_host()->GetWidget()->is_hidden() !=
- delegate_->IsHidden()) {
+ RenderWidgetHostView* view = GetRenderWidgetHostView();
+ if (view && static_cast<RenderWidgetHostImpl*>(view->GetRenderWidgetHost())
+ ->is_hidden() != delegate_->IsHidden()) {
if (delegate_->IsHidden()) {
- render_frame_host_->GetView()->Hide();
+ view->Hide();
} else {
- render_frame_host_->GetView()->Show();
+ view->Show();
}
}
}
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698