Reparent all tabs when entering/exiting VR.

Reparent all tabs when entering/exiting VR.

This fixes the issue where tabs would resize incorrectly at first when
opening or closing tabs, by reparenting all tabs when entering VR, making
sure that tabs are created in the right window, and restoring the original
window when done.

BUG=730758
Review-Url: https://codereview.chromium.org/2938253002
Cr-Commit-Position: refs/heads/master@{#480067}
Committed: https://chromium.googlesource.com/chromium/src/+/64d448d5f2a145aee27eb2648d8c7324add3a6a9

[mthiesse, 2017-06-15 18:56:16]

mthiesse@chromium.org changed reviewers:
+ boliu@chromium.org, tedchoc@chromium.org

[mthiesse, 2017-06-15 18:56:16]

Boliu, PTAL
+TedChoc for ChromeTabCreator.java OWNERS

[mthiesse, 2017-06-15 18:56:46]

https://codereview.chromium.org/2938253002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
(right):

https://codereview.chromium.org/2938253002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java:340:
public void setWindowAndroid(WindowAndroid window) {
Alternatively we could replace the whole TabCreator, rather than just replacing
the WindowAndroid here. Would that be preferable?

[boliu, 2017-06-15 19:05:32]

lg2m

[Ted C, 2017-06-16 00:06:02]

lgtm

https://codereview.chromium.org/2938253002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2938253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:495:
overrideTabCreatorWindow(window);
should we have a single method to update the window references?  you're calling
override and reparent in both places and it might be less error prone to do it
in a single place

[mthiesse, 2017-06-16 14:41:52]

https://codereview.chromium.org/2938253002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2938253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:495:
overrideTabCreatorWindow(window);
On 2017/06/16 00:06:02, Ted C wrote:
> should we have a single method to update the window references?  you're
calling
> override and reparent in both places and it might be less error prone to do it
> in a single place

Done.

[mthiesse, 2017-06-16 14:41:56]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-06-16 14:41:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2938253002/#ps40001
(title: "Address comments + add assert just in case")

[commit-bot: I haz the power, 2017-06-16 14:42:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 16:25:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497624116028070,
"parent_rev": "6b8ccbdffb886e191fe595c58c7afc86b0e1c03a", "commit_rev":
"64d448d5f2a145aee27eb2648d8c7324add3a6a9"}

[commit-bot: I haz the power, 2017-06-16 16:25:32]

Description was changed from

==========
Reparent all tabs when entering/exiting VR.

This fixes the issue where tabs would resize incorrectly at first when
opening or closing tabs, by reparenting all tabs when entering VR, making
sure that tabs are created in the right window, and restoring the original
window when done.

BUG=730758
==========

to

==========
Reparent all tabs when entering/exiting VR.

This fixes the issue where tabs would resize incorrectly at first when
opening or closing tabs, by reparenting all tabs when entering VR, making
sure that tabs are created in the right window, and restoring the original
window when done.

BUG=730758

Review-Url: https://codereview.chromium.org/2938253002
Cr-Commit-Position: refs/heads/master@{#480067}
Committed:
https://chromium.googlesource.com/chromium/src/+/64d448d5f2a145aee27eb2648d8c...
==========

[commit-bot: I haz the power, 2017-06-16 16:25:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/64d448d5f2a145aee27eb2648d8c...