Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3026)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2938253002: Reparent all tabs when entering/exiting VR. (Closed)
Patch Set: Address comments + add assert just in case Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
index 7090118b39022e7a39275700c0bb711ce71b7d8b..103e6919c126c6ef39549d1f16201dc54edb5a31 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
@@ -32,9 +32,9 @@ import org.chromium.ui.base.WindowAndroid;
public class ChromeTabCreator extends TabCreatorManager.TabCreator {
private final ChromeActivity mActivity;
- private final WindowAndroid mNativeWindow;
private final boolean mIncognito;
+ private WindowAndroid mNativeWindow;
private TabModel mTabModel;
private TabContentManager mTabContentManager;
private TabModelOrderController mOrderController;
@@ -334,4 +334,10 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
return new TabDelegateFactory();
}
+ /**
+ * Sets the window to create tabs for.
+ */
+ public void setWindowAndroid(WindowAndroid window) {
+ mNativeWindow = window;
+ }
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698