Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2938193003: Revert "Towards compiling Hello World!" and "Compile and run Hello World!" (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Towards compiling Hello World!" and "Compile and run Hello World!" This reverts commit 778feb0504759885271e166d76f0924c3bdfdb08 and 1214e6fba636d76fca88357c358990c24b08c756. Committed: https://github.com/dart-lang/sdk/commit/482502705ad05b6a14017f30b12909d97b322bdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -494 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 6 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 9 chunks +19 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 7 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 9 chunks +24 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 6 chunks +11 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 3 chunks +20 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 4 chunks +0 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 3 chunks +0 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 3 chunks +4 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +48 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 9 chunks +7 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 3 chunks +31 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +2 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 7 chunks +9 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 2 chunks +5 lines, -12 lines 0 comments Download
D tests/compiler/dart2js/kernel/run_from_dill_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
3 years, 6 months ago (2017-06-16 09:33:18 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 482502705ad05b6a14017f30b12909d97b322bdf (presubmit successful).
3 years, 6 months ago (2017-06-16 09:34:12 UTC) #4
ahe
3 years, 6 months ago (2017-06-16 10:21:18 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698