Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: pkg/compiler/lib/src/ssa/ssa.dart

Issue 2938193003: Revert "Towards compiling Hello World!" and "Compile and run Hello World!" (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart ('k') | pkg/compiler/lib/src/ssa/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/ssa.dart
diff --git a/pkg/compiler/lib/src/ssa/ssa.dart b/pkg/compiler/lib/src/ssa/ssa.dart
index f92272a03c8ec359ce977e40753dedc6e1b7a7ab..ba197d12af9873c12ad2612799e0473dfeb92b79 100644
--- a/pkg/compiler/lib/src/ssa/ssa.dart
+++ b/pkg/compiler/lib/src/ssa/ssa.dart
@@ -4,16 +4,13 @@
library ssa;
-import '../common/codegen.dart' show CodegenWorkItem, CodegenRegistry;
+import '../common/codegen.dart' show CodegenWorkItem;
import '../common/tasks.dart' show CompilerTask, Measurer;
-import '../constants/values.dart';
import '../elements/elements.dart' show MethodElement;
-import '../elements/entities.dart' show FieldEntity, MemberEntity;
+import '../elements/entities.dart' show MemberEntity;
import '../io/source_information.dart';
import '../js/js.dart' as js;
import '../js_backend/backend.dart' show JavaScriptBackend, FunctionCompiler;
-import '../universe/call_structure.dart';
-import '../universe/use.dart';
import '../world.dart' show ClosedWorld;
import 'codegen.dart';
@@ -60,44 +57,3 @@ abstract class SsaBuilderTask implements CompilerTask {
/// for [work].
HGraph build(CodegenWorkItem work, ClosedWorld closedWorld);
}
-
-abstract class SsaBuilderFieldMixin {
- ConstantValue getFieldInitialConstantValue(FieldEntity field);
-
- /// Handle field initializer of [element]. Returns `true` if no code
- /// is needed for the field.
- ///
- /// If [element] is a field with a constant initializer, the value is
- /// registered with the world impact. Otherwise the cyclic-throw helper is
- /// registered for the lazy value computation.
- ///
- /// If the field is constant, no code is needed for the field and the method
- /// returns `true`.
- bool handleConstantField(
- MemberEntity element, CodegenRegistry registry, ClosedWorld closedWorld) {
- if (element.isField) {
- ConstantValue initialValue = getFieldInitialConstantValue(element);
- if (initialValue != null) {
- registry.worldImpact
- .registerConstantUse(new ConstantUse.init(initialValue));
- // We don't need to generate code for static or top-level
- // variables. For instance variables, we may need to generate
- // the checked setter.
- if (element.isStatic || element.isTopLevel) {
- /// No code is created for this field: All references inline the
- /// constant value.
- return true;
- }
- } else {
- // If the constant-handler was not able to produce a result we have to
- // go through the builder (below) to generate the lazy initializer for
- // the static variable.
- // We also need to register the use of the cyclic-error helper.
- registry.worldImpact.registerStaticUse(new StaticUse.staticInvoke(
- closedWorld.commonElements.cyclicThrowHelper,
- CallStructure.ONE_ARG));
- }
- }
- return false;
- }
-}
« no previous file with comments | « pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart ('k') | pkg/compiler/lib/src/ssa/types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698