pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 2938193003: Revert "Towards compiling Hello World!" and "Compile and run Hello World!"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 2938193003: Revert "Towards compiling Hello World!" and "Compile and run Hello World!" (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index a38591a9b70567a3e065437ea119291ed3c6926e..5131953a354a206a478b8a6a6bd8c3520ffe4c26 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -5,7 +5,7 @@

library dart2js.js_emitter.runtime_type_generator;

import '../closure.dart'

- show ClosureRepresentationInfo, ClosureFieldElement, ClosureConversionTask;

+ show ClosureRepresentationInfo, ClosureFieldElement, ClosureTask;

import '../common.dart';

import '../common/names.dart' show Identifiers;

import '../common_elements.dart' show CommonElements;

@@ -14,7 +14,6 @@ import '../elements/resolution_types.dart'

import '../elements/elements.dart'

show ClassElement, Element, FunctionElement, MixinApplicationElement;

import '../elements/entities.dart';

-import '../elements/types.dart';

import '../js/js.dart' as jsAst;

import '../js/js.dart' show js;

import '../js_backend/js_interop_analysis.dart';

@@ -58,7 +57,7 @@ class TypeTestProperties {

class RuntimeTypeGenerator {

final CommonElements _commonElements;

- final ClosureConversionTask _closureDataLookup;

+ final ClosureTask _closureDataLookup;

final CodeEmitterTask emitterTask;

final Namer _namer;

final NativeData _nativeData;

@@ -82,12 +81,12 @@ class RuntimeTypeGenerator {

TypeTestRegistry get _typeTestRegistry => emitterTask.typeTestRegistry;

- Set<ClassEntity> get checkedClasses => _typeTestRegistry.checkedClasses;

+ Set<ClassElement> get checkedClasses => _typeTestRegistry.checkedClasses;

- Iterable<ClassEntity> get classesUsingTypeVariableTests =>

+ Iterable<ClassElement> get classesUsingTypeVariableTests =>

_typeTestRegistry.classesUsingTypeVariableTests;

- Set<FunctionType> get checkedFunctionTypes =>

+ Set<ResolutionFunctionType> get checkedFunctionTypes =>

_typeTestRegistry.checkedFunctionTypes;

/// Generates all properties necessary for is-checks on the [classElement].