Use ContainsValue() instead of std::find() in tools/

Use ContainsValue() instead of std::find() in tools/

BUG=561800
Review-Url: https://codereview.chromium.org/2938163003
Cr-Commit-Position: refs/heads/master@{#480018}
Committed: https://chromium.googlesource.com/chromium/src/+/3e0d5228e24db43bb266c19ed82782be7239bb9b

[Tripta, 2017-06-15 08:32:49]

Description was changed from

==========
Use ContainsValue() instead of std::find() in tools/

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in tools/

BUG=561800
==========

[Tripta, 2017-06-15 08:32:49]

tripta.g@samsung.com changed reviewers:
+ brettw@chromium.org

[Tripta, 2017-06-15 08:34:07]

Hi brettw,

Please review code changes for following files:

  tools/gn/action_target_generator.cc
  tools/gn/function_process_file_template.cc
  tools/gn/runtime_deps_unittest.cc
  tools/gn/target.cc

Regards
Tripta

[brettw, 2017-06-15 21:02:30]

lgtm

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
File tools/gn/function_process_file_template.cc (right):

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
tools/gn/function_process_file_template.cc:98: if
(base::ContainsValue(types,SUBSTITUTION_SOURCE_TARGET_RELATIVE) {
Space before period.

[brettw, 2017-06-15 21:02:44]

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
File tools/gn/function_process_file_template.cc (right):

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
tools/gn/function_process_file_template.cc:98: if
(base::ContainsValue(types,SUBSTITUTION_SOURCE_TARGET_RELATIVE) {
On 2017/06/15 21:02:30, brettw wrote:
> Space before period.

I mean comma, sorry.

[Tripta, 2017-06-16 11:13:57]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-16 11:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2938163003/#ps20001
(title: "Added a space after comma.")

[commit-bot: I haz the power, 2017-06-16 11:14:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-16 11:17:29]

Have added a space after comma. Please check.

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
File tools/gn/function_process_file_template.cc (right):

https://codereview.chromium.org/2938163003/diff/1/tools/gn/function_process_f...
tools/gn/function_process_file_template.cc:98: if
(base::ContainsValue(types,SUBSTITUTION_SOURCE_TARGET_RELATIVE) {
On 2017/06/15 21:02:44, brettw wrote:
> On 2017/06/15 21:02:30, brettw wrote:
> > Space before period.
> 
> I mean comma, sorry.

Have added a space after comma.

[commit-bot: I haz the power, 2017-06-16 11:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 11:20:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tripta, 2017-06-16 11:26:51]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-16 11:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2938163003/#ps40001
(title: "Fixing build error.")

[commit-bot: I haz the power, 2017-06-16 11:26:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 11:39:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497612411283650,
"parent_rev": "9ea317b97a564286aadf81bfe3d2bcb1d0e642cc", "commit_rev":
"3e0d5228e24db43bb266c19ed82782be7239bb9b"}

[commit-bot: I haz the power, 2017-06-16 11:39:51]

Description was changed from

==========
Use ContainsValue() instead of std::find() in tools/

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in tools/

BUG=561800

Review-Url: https://codereview.chromium.org/2938163003
Cr-Commit-Position: refs/heads/master@{#480018}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e0d5228e24db43bb266c19ed827...
==========

[commit-bot: I haz the power, 2017-06-16 11:39:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e0d5228e24db43bb266c19ed827...