Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/gn/target.cc

Issue 2938163003: Use ContainsValue() instead of std::find() in tools/ (Closed)
Patch Set: Fixing build error. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/runtime_deps_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 759d7bff14493e59663830c67f2259562eb28f11..f8af71588f0ef49e3df22a829809a84037309fe2 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -6,9 +6,8 @@
#include <stddef.h>
-#include <algorithm>
-
#include "base/bind.h"
+#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "tools/gn/config_values_extractors.h"
@@ -95,8 +94,7 @@ bool EnsureFileIsGeneratedByDependency(const Target* target,
Toolchain::ToolType tool_type;
if (!target->GetOutputFilesForSource(source, &tool_type, &source_outputs))
continue;
- if (std::find(source_outputs.begin(), source_outputs.end(), file) !=
- source_outputs.end())
+ if (base::ContainsValue(source_outputs, file))
return true;
}
}
« no previous file with comments | « tools/gn/runtime_deps_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698