Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and
AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis.

BUG=728491, 722679
Review-Url: https://codereview.chromium.org/2938133003
Cr-Commit-Position: refs/heads/master@{#482184}
Committed: https://chromium.googlesource.com/chromium/src/+/ef37fe771b578f8abc44c9fb5a6e28500aee0353

[renjieliu1, 2017-06-15 04:49:26]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 04:49:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 06:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 06:24:15]

Dry run: This issue passed the CQ dry run.

[renjieliu1, 2017-06-15 06:55:46]

Description was changed from

==========
Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and
AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis.

BUG=728491, 722679
==========

to

==========
Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and
AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis.

BUG=728491, 722679
==========

[renjieliu1, 2017-06-15 06:55:47]

renjieliu@chromium.org changed reviewers:
+ napper@chromium.org

[napper, 2017-06-15 12:40:47]

napper@chromium.org changed reviewers:
+ hamelphi@chromium.org

[napper, 2017-06-15 12:40:47]

lgtm

[hamelphi, 2017-06-15 15:25:18]

lgtm

[renjieliu1, 2017-06-15 23:57:28]

The CQ bit was checked by renjieliu@chromium.org

[commit-bot: I haz the power, 2017-06-15 23:57:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 23:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 23:57:52]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[renjieliu1, 2017-06-16 00:02:47]

renjieliu@chromium.org changed reviewers:
+ skym@chromium.org

[skym, 2017-06-16 18:09:31]

lgtm

[renjieliu1, 2017-06-19 00:10:46]

renjieliu@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2017-06-20 04:17:17]

LGTM % comment nits

https://codereview.chromium.org/2938133003/diff/1/components/metrics/proto/tr...
File components/metrics/proto/translate_event.proto (right):

https://codereview.chromium.org/2938133003/diff/1/components/metrics/proto/tr...
components/metrics/proto/translate_event.proto:101: AUTO_TRANSLATION_BY_PREF =
25;
Could you comment on what the difference between the two is?

https://codereview.chromium.org/2938133003/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2938133003/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:66: AUTO_TRANSLATION_BY_PREF
= 7;
Please comment on the difference. (It's obvious right now, it won't be to the
engineer reading it in two or three years :)

[renjieliu1, 2017-06-20 04:51:38]

thanks for the review!

https://codereview.chromium.org/2938133003/diff/1/components/metrics/proto/tr...
File components/metrics/proto/translate_event.proto (right):

https://codereview.chromium.org/2938133003/diff/1/components/metrics/proto/tr...
components/metrics/proto/translate_event.proto:101: AUTO_TRANSLATION_BY_PREF =
25;
On 2017/06/20 04:17:17, groby wrote:
> Could you comment on what the difference between the two is?

Done.

https://codereview.chromium.org/2938133003/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2938133003/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:66: AUTO_TRANSLATION_BY_PREF
= 7;
On 2017/06/20 04:17:17, groby wrote:
> Please comment on the difference. (It's obvious right now, it won't be to the
> engineer reading it in two or three years :)

Done.

[renjieliu1, 2017-06-20 05:13:11]

The CQ bit was checked by renjieliu@chromium.org

[renjieliu1, 2017-06-20 05:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from napper@chromium.org,
hamelphi@chromium.org, skym@chromium.org, groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2938133003/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2017-06-20 05:13:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 05:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 05:19:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[renjieliu1, 2017-06-20 05:27:25]

renjieliu@chromium.org changed reviewers:
+ holte@chromium.org

[renjieliu1, 2017-06-20 05:28:02]

Hi Steven,

Can you do onwer review for the metrics proto?

Thanks a lot!

[holte, 2017-06-20 22:16:14]

holte@google.com changed reviewers:
+ holte@google.com

[holte, 2017-06-20 22:16:15]

Have you already updated the internal version of the proto file?

[renjieliu1, 2017-06-20 23:13:41]

On 2017/06/20 22:16:15, holte wrote:
> Have you already updated the internal version of the proto file?

thank you for pointing this out! I will do this in a following cl!

[holte, 2017-06-21 14:59:27]

On 2017/06/20 23:13:41, renjieliu1 wrote:
> On 2017/06/20 22:16:15, holte wrote:
> > Have you already updated the internal version of the proto file?
> 
> thank you for pointing this out! I will do this in a following cl!

You should actually do that first, since you need to get approval from Logs for
those files, though in this case it should be quick.

[holte, 2017-06-21 15:16:32]

On 2017/06/21 14:59:27, holte wrote:
> On 2017/06/20 23:13:41, renjieliu1 wrote:
> > On 2017/06/20 22:16:15, holte wrote:
> > > Have you already updated the internal version of the proto file?
> > 
> > thank you for pointing this out! I will do this in a following cl!
> 
> You should actually do that first, since you need to get approval from Logs
for
> those files, though in this case it should be quick.

lgtm once that change lands

[Steven Holte, 2017-06-21 15:17:47]

On 2017/06/21 15:16:32, holte wrote:
> On 2017/06/21 14:59:27, holte wrote:
> > On 2017/06/20 23:13:41, renjieliu1 wrote:
> > > On 2017/06/20 22:16:15, holte wrote:
> > > > Have you already updated the internal version of the proto file?
> > > 
> > > thank you for pointing this out! I will do this in a following cl!
> > 
> > You should actually do that first, since you need to get approval from Logs
> for
> > those files, though in this case it should be quick.
> 
> lgtm once that change lands

lgtm once that change lands from @chromium

[renjieliu1, 2017-06-26 00:37:58]

On 2017/06/21 15:17:47, Steven Holte wrote:
> On 2017/06/21 15:16:32, holte wrote:
> > On 2017/06/21 14:59:27, holte wrote:
> > > On 2017/06/20 23:13:41, renjieliu1 wrote:
> > > > On 2017/06/20 22:16:15, holte wrote:
> > > > > Have you already updated the internal version of the proto file?
> > > > 
> > > > thank you for pointing this out! I will do this in a following cl!
> > > 
> > > You should actually do that first, since you need to get approval from
Logs
> > for
> > > those files, though in this case it should be quick.
> > 
> > lgtm once that change lands
> 
> lgtm once that change lands from @chromium

Thank you! The google3 cl is landed: cl/160095265

[renjieliu1, 2017-06-26 00:38:20]

The CQ bit was checked by renjieliu@chromium.org

[commit-bot: I haz the power, 2017-06-26 00:38:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 02:24:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498437500158410,
"parent_rev": "7fb24c38a5ca6408e02d6ac9c76f2e233ba68e40", "commit_rev":
"ef37fe771b578f8abc44c9fb5a6e28500aee0353"}

[commit-bot: I haz the power, 2017-06-26 02:24:29]

Description was changed from

==========
Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and
AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis.

BUG=728491, 722679
==========

to

==========
Split translate_event.proto AUTOMATICALLY_TRANSLATED.

Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and
AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis.

BUG=728491, 722679

Review-Url: https://codereview.chromium.org/2938133003
Cr-Commit-Position: refs/heads/master@{#482184}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef37fe771b578f8abc44c9fb5a6e...
==========

[commit-bot: I haz the power, 2017-06-26 02:24:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ef37fe771b578f8abc44c9fb5a6e...