Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2937913002: Revert of Create BUILD.gn files for //media/filters. (Closed)

Created:
3 years, 6 months ago by Henrik Grunell
Modified:
3 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create BUILD.gn files for //media/filters. (patchset #13 id:240001 of https://codereview.chromium.org/2911643002/ ) Reason for revert: Speculative revert to see if it caused the failure on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 (I'll re-land if it didn't.) Original issue's description: > Create BUILD.gn files for //media/filters. > > Create new BUILD.gn file for media/filters and moved respective > media component changes from media/BUILD.gn file to new BUILD.gn > file. > > BUG=613033 > > R=dalecurtis@chromium.org > > Review-Url: https://codereview.chromium.org/2911643002 > Cr-Commit-Position: refs/heads/master@{#479280} > Committed: https://chromium.googlesource.com/chromium/src/+/f4492feec756684e4873073648fa3504f41a20b6 TBR=mlamouri@chromium.org,a.suchit@chromium.org,dalecurtis@chromium.org,phajdan@google.com,a.suchit@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613033 Review-Url: https://codereview.chromium.org/2937913002 Cr-Commit-Position: refs/heads/master@{#479330} Committed: https://chromium.googlesource.com/chromium/src/+/54527a18f625f91ae7cc6a00eae26102323e38a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -298 lines) Patch
M media/BUILD.gn View 5 chunks +222 lines, -1 line 0 comments Download
M media/base/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M media/base/mac/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
D media/filters/BUILD.gn View 1 chunk +0 lines, -288 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Henrik Grunell
Created Revert of Create BUILD.gn files for //media/filters.
3 years, 6 months ago (2017-06-14 08:53:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937913002/1
3 years, 6 months ago (2017-06-14 08:53:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54527a18f625f91ae7cc6a00eae26102323e38a9
3 years, 6 months ago (2017-06-14 08:53:56 UTC) #6
Henrik Grunell
3 years, 6 months ago (2017-06-14 10:09:05 UTC) #7
Message was sent while issue was closed.
The revert did fix the failure.

Powered by Google App Engine
This is Rietveld 408576698