Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2911643002:
Create BUILD.gn files for //media/filters. (Closed)
DescriptionCreate BUILD.gn files for //media/filters.
Create new BUILD.gn file for media/filters and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.
BUG=613033
R=dalecurtis@chromium.org
Review-Url: https://codereview.chromium.org/2911643002
Cr-Commit-Position: refs/heads/master@{#479280}
Committed: https://chromium.googlesource.com/chromium/src/+/f4492feec756684e4873073648fa3504f41a20b6
Patch Set 1 #Patch Set 2 : Fixed Mac, Win and android build issues. #Patch Set 3 : missed 1 file in patch set 2 #Patch Set 4 : Reset. #Patch Set 5 : Fixed mac, android build issues. #Patch Set 6 : Fixed Mac build error. #Patch Set 7 : Fix mac build. #
Total comments: 3
Patch Set 8 : Removed opus_constants files changes. #Patch Set 9 : Fixed libvpx dependency for media library. #Patch Set 10 : Create BUILD.gn files for //media/filters. #Patch Set 11 : # #Patch Set 12 : Reset patch set 9. #Patch Set 13 : media configs added gor filter target. #
Messages
Total messages: 54 (39 generated)
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn File media/filters/BUILD.gn (right): https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn... media/filters/BUILD.gn:13: if (media_use_ffmpeg) { line above.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/31 21:12:31, DaleCurtis wrote: > lgtm > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn > File media/filters/BUILD.gn (right): > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn... > media/filters/BUILD.gn:13: if (media_use_ffmpeg) { > line above. Some tests are still failing. I need to look that and fix. I started dry run on latest patch set. Patch set 5 have the failed bots.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
On 2017/06/01 00:13:12, a.suchit2 wrote: > On 2017/05/31 21:12:31, DaleCurtis wrote: > > lgtm > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn > > File media/filters/BUILD.gn (right): > > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/BUILD.gn... > > media/filters/BUILD.gn:13: if (media_use_ffmpeg) { > > line above. > > Some tests are still failing. > I need to look that and fix. > I started dry run on latest patch set. > Patch set 5 have the failed bots. I am not getting that why are tests failing. Changes are related to only build. All failed tests are for android only.
dalecurtis@chromium.org changed reviewers: + mlamouri@chromium.org
Looks like the assets (test html file) aren't being propagated to the tests for some reason. +mlamouri who might know which DEP is missing
I looked a bit and tried locally but couldn't find an obvious issue. The test file not loading doesn't seem to be the correct issue as I could see the file loading locally. Many webview tests are also failing. Let me know if you want me to look into this deeper. https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... File media/filters/opus_constants.h (right): https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... media/filters/opus_constants.h:10: #include "media/base/media_export.h" Why are you adding this?
> Let me know if you want me to look into this deeper. If you will check some more deeper and help me to solve it then it would be better because I do not have idea about test environment setup. Thanks in advance ... https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... File media/filters/opus_constants.h (right): https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... media/filters/opus_constants.h:10: #include "media/base/media_export.h" On 2017/06/05 12:30:16, mlamouri wrote: > Why are you adding this? It is not needed. I forgot to remove it. I will Update it later.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Description was changed from ========== Create BUILD.gn files for //media/filters. Create new BUILD.gn file for media/filters and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033 R=dalecurtis@chromium.org ========== to ========== Create BUILD.gn files for //media/filters. Create new BUILD.gn file for media/filters and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033 R=dalecurtis@chromium.org ==========
a.suchit@chromium.org changed reviewers: + phajdan@google.com
On 2017/06/05 18:22:25, a.suchit2 wrote: > > Let me know if you want me to look into this deeper. > > If you will check some more deeper and help me to solve it then it would be > better because I do not have idea about test environment setup. > > Thanks in advance ... > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > File media/filters/opus_constants.h (right): > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > media/filters/opus_constants.h:10: #include "media/base/media_export.h" > On 2017/06/05 12:30:16, mlamouri wrote: > > Why are you adding this? > > It is not needed. > I forgot to remove it. > I will Update it later. @mlamouri Have you tried more about the test failure ? I tried some of the things but that did not solve it.
On 2017/06/12 08:14:27, a.suchit2 wrote: > On 2017/06/05 18:22:25, a.suchit2 wrote: > > > Let me know if you want me to look into this deeper. > > > > If you will check some more deeper and help me to solve it then it would be > > better because I do not have idea about test environment setup. > > > > Thanks in advance ... > > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > > File media/filters/opus_constants.h (right): > > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > > media/filters/opus_constants.h:10: #include "media/base/media_export.h" > > On 2017/06/05 12:30:16, mlamouri wrote: > > > Why are you adding this? > > > > It is not needed. > > I forgot to remove it. > > I will Update it later. > > @mlamouri > Have you tried more about the test failure ? > I tried some of the things but that did not solve it. I am not able to run the "CQ dry run".
On 2017/06/13 at 07:34:14, a.suchit wrote: > On 2017/06/12 08:14:27, a.suchit2 wrote: > > On 2017/06/05 18:22:25, a.suchit2 wrote: > > > > Let me know if you want me to look into this deeper. > > > > > > If you will check some more deeper and help me to solve it then it would be > > > better because I do not have idea about test environment setup. > > > > > > Thanks in advance ... > > > > > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > > > File media/filters/opus_constants.h (right): > > > > > > > > https://codereview.chromium.org/2911643002/diff/120001/media/filters/opus_con... > > > media/filters/opus_constants.h:10: #include "media/base/media_export.h" > > > On 2017/06/05 12:30:16, mlamouri wrote: > > > > Why are you adding this? > > > > > > It is not needed. > > > I forgot to remove it. > > > I will Update it later. > > > > @mlamouri > > Have you tried more about the test failure ? > > I tried some of the things but that did not solve it. > > I am not able to run the "CQ dry run". I see you've opened https://chromium-review.googlesource.com/c/532694/ and I left some feedback there.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I am committing this patch from here and next patch onward, I will gerrit only.
I am committing this patch from here and next patch onward, I will gerrit only.
The CQ bit was checked by a.suchit@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/2911643002/#ps240001 (title: "media configs added gor filter target.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 240001, "attempt_start_ts": 1497413395087810,
"parent_rev": "864784a313f583c72917cb706418088ca2311c52", "commit_rev":
"f4492feec756684e4873073648fa3504f41a20b6"}
Message was sent while issue was closed.
Description was changed from ========== Create BUILD.gn files for //media/filters. Create new BUILD.gn file for media/filters and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033 R=dalecurtis@chromium.org ========== to ========== Create BUILD.gn files for //media/filters. Create new BUILD.gn file for media/filters and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033 R=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2911643002 Cr-Commit-Position: refs/heads/master@{#479280} Committed: https://chromium.googlesource.com/chromium/src/+/f4492feec756684e4873073648fa... ==========
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as https://chromium.googlesource.com/chromium/src/+/f4492feec756684e4873073648fa...
Message was sent while issue was closed.
A revert of this CL (patchset #13 id:240001) has been created in https://codereview.chromium.org/2937913002/ by grunell@chromium.org. The reason for reverting is: Speculative revert to see if it caused the failure on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 (I'll re-land if it didn't.).
Message was sent while issue was closed.
Findit (https://goo.gl/kROfz5) identified this CL at revision 479280 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
