Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2937693002: [ios] Disables WindowLocationTest.WindowLocationSetToDOMString on device. (Closed)

Created:
3 years, 6 months ago by rohitrao (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
mrefaat, *sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Disables WindowLocationTest.WindowLocationSetToDOMString on device. This test occasionally times out on iOS 9.3.2 devices. BUG=731740 Review-Url: https://codereview.chromium.org/2937693002 Cr-Commit-Position: refs/heads/master@{#478987} Committed: https://chromium.googlesource.com/chromium/src/+/4fc8601f5e8bc4bcefed93f3edefbb70dc163fbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ios/web/navigation/window_location_inttest.mm View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
rohitrao (ping after 24h)
3 years, 6 months ago (2017-06-13 11:57:52 UTC) #5
sdefresne
lgtm
3 years, 6 months ago (2017-06-13 12:45:35 UTC) #8
sdefresne
lgtm
3 years, 6 months ago (2017-06-13 12:45:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937693002/1
3 years, 6 months ago (2017-06-13 12:46:07 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 12:50:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fc8601f5e8bc4bcefed93f3edef...

Powered by Google App Engine
This is Rietveld 408576698