Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: ios/web/navigation/window_location_inttest.mm

Issue 2937693002: [ios] Disables WindowLocationTest.WindowLocationSetToDOMString on device. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/window_location_inttest.mm
diff --git a/ios/web/navigation/window_location_inttest.mm b/ios/web/navigation/window_location_inttest.mm
index 4637b9d1365681c636554ab97b04bb61ecdc038e..af3d7827eb000573436ed7972c8261a7a36b31d1 100644
--- a/ios/web/navigation/window_location_inttest.mm
+++ b/ios/web/navigation/window_location_inttest.mm
@@ -222,7 +222,14 @@ TEST_F(WindowLocationTest, MAYBE_WindowLocationReload) {
}
// Tests that calling window.location.assign() creates a new NavigationItem.
-TEST_F(WindowLocationTest, WindowLocationSetToDOMString) {
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_WindowLocationSetToDOMString WindowLocationSetToDOMString
+#else
+#define MAYBE_WindowLocationSetToDOMString DISABLED_WindowLocationSetToDOMString
+#endif
+// TODO(crbug.com/731740): This test is disabled because it occasionally times
+// out on device.
+TEST_F(WindowLocationTest, MAYBE_WindowLocationSetToDOMString) {
// Navigate to about:blank so there is a forward entry to prune.
GURL about_blank("about:blank");
LoadUrl(about_blank);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698