[Extensions] Simplify EventFilteringInfo

[Extensions] Simplify EventFilteringInfo

EventFilteringInfo currently has a bunch of parameters and boolean flags
indicating whether or not it "has" those parameters. This can be greatly
simplified with base::Optional. Use base::Optional for all the members
in EventFilteringInfo and, since it only exposed getters/setters, make
it a struct.

This cleanup will be very useful in passing the filtering info directly
over IPC.

BUG=732564
Review-Url: https://codereview.chromium.org/2937623002
Cr-Commit-Position: refs/heads/master@{#479412}
Committed: https://chromium.googlesource.com/chromium/src/+/22da9e8bfbd02c8052f076e59e203bd2dd74c4eb

[Devlin, 2017-06-13 00:39:27]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:39:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 01:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 01:30:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-13 22:58:49]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 22:59:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-14 00:09:33]

Description was changed from

==========
simplify

BUG=
==========

to

==========
[Extensions] Simplify EventFilteringInfo

EventFilteringInfo currently has a bunch of parameters and boolean flags
indicating whether or not it "has" those parameters. This can be greatly
simplified with base::Optional. Use base::Optional for all the members
in EventFilteringInfo and, since it only exposed getters/setters, make
it a struct.

This cleanup will be very useful in passing the filtering info directly
over IPC.

BUG=732564
==========

[Devlin, 2017-06-14 00:10:04]

rdevlin.cronin@chromium.org changed reviewers:
+ karandeepb@chromium.org

[Devlin, 2017-06-14 00:10:04]

karandeepb@, mind taking a look?

lazyboy@, FYI since we're both touching event-y code.

[commit-bot: I haz the power, 2017-06-14 00:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 00:10:18]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2017-06-14 01:48:20]

LGTM with nits.

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
File extensions/common/event_filtering_info.cc (right):

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
extensions/common/event_filtering_info.cc:32: url = maybe_url;
std::move this?

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
extensions/common/event_filtering_info.cc:36: if (dict.GetInteger(kInstanceId,
&dict_instance_id))
nit: Would be better to enclose each member initialization in curly brace
especially to ensure moved variables are not re-used.

[Devlin, 2017-06-14 15:09:34]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 15:10:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-14 16:02:27]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-14 16:02:36]

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
File extensions/common/event_filtering_info.cc (right):

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
extensions/common/event_filtering_info.cc:32: url = maybe_url;
On 2017/06/14 01:48:19, karandeepb wrote:
> std::move this?

GURL finally has move semantics?  Yay!  Done.

https://codereview.chromium.org/2937623002/diff/20001/extensions/common/event...
extensions/common/event_filtering_info.cc:36: if (dict.GetInteger(kInstanceId,
&dict_instance_id))
On 2017/06/14 01:48:19, karandeepb wrote:
> nit: Would be better to enclose each member initialization in curly brace
> especially to ensure moved variables are not re-used. 

sure, can't hurt.  Done.

[Devlin, 2017-06-14 16:02:40]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-14 16:02:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
karandeepb@chromium.org
Link to the patchset: https://codereview.chromium.org/2937623002/#ps40001
(title: "karan's")

[commit-bot: I haz the power, 2017-06-14 16:03:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 16:28:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497456160611150,
"parent_rev": "5f556b51553f6a8b163987dc56594f337192f38d", "commit_rev":
"22da9e8bfbd02c8052f076e59e203bd2dd74c4eb"}

[commit-bot: I haz the power, 2017-06-14 16:28:47]

Description was changed from

==========
[Extensions] Simplify EventFilteringInfo

EventFilteringInfo currently has a bunch of parameters and boolean flags
indicating whether or not it "has" those parameters. This can be greatly
simplified with base::Optional. Use base::Optional for all the members
in EventFilteringInfo and, since it only exposed getters/setters, make
it a struct.

This cleanup will be very useful in passing the filtering info directly
over IPC.

BUG=732564
==========

to

==========
[Extensions] Simplify EventFilteringInfo

EventFilteringInfo currently has a bunch of parameters and boolean flags
indicating whether or not it "has" those parameters. This can be greatly
simplified with base::Optional. Use base::Optional for all the members
in EventFilteringInfo and, since it only exposed getters/setters, make
it a struct.

This cleanup will be very useful in passing the filtering info directly
over IPC.

BUG=732564

Review-Url: https://codereview.chromium.org/2937623002
Cr-Commit-Position: refs/heads/master@{#479412}
Committed:
https://chromium.googlesource.com/chromium/src/+/22da9e8bfbd02c8052f076e59e20...
==========

[commit-bot: I haz the power, 2017-06-14 16:28:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/22da9e8bfbd02c8052f076e59e20...