Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

Issue 2937623002: [Extensions] Simplify EventFilteringInfo (Closed)
Patch Set: karan's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/event_listener_map_unittest.cc ('k') | extensions/common/event_filter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h " 5 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h "
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "components/guest_view/browser/guest_view_base.h" 9 #include "components/guest_view/browser/guest_view_base.h"
10 #include "components/guest_view/browser/guest_view_manager.h" 10 #include "components/guest_view/browser/guest_view_manager.h"
(...skipping 25 matching lines...) Expand all
36 36
37 ExtensionsGuestViewManagerDelegate::~ExtensionsGuestViewManagerDelegate() { 37 ExtensionsGuestViewManagerDelegate::~ExtensionsGuestViewManagerDelegate() {
38 } 38 }
39 39
40 void ExtensionsGuestViewManagerDelegate::DispatchEvent( 40 void ExtensionsGuestViewManagerDelegate::DispatchEvent(
41 const std::string& event_name, 41 const std::string& event_name,
42 std::unique_ptr<base::DictionaryValue> args, 42 std::unique_ptr<base::DictionaryValue> args,
43 GuestViewBase* guest, 43 GuestViewBase* guest,
44 int instance_id) { 44 int instance_id) {
45 EventFilteringInfo info; 45 EventFilteringInfo info;
46 info.SetInstanceID(instance_id); 46 info.instance_id = instance_id;
47 std::unique_ptr<base::ListValue> event_args(new base::ListValue()); 47 std::unique_ptr<base::ListValue> event_args(new base::ListValue());
48 event_args->Append(std::move(args)); 48 event_args->Append(std::move(args));
49 49
50 // GetEventHistogramValue maps guest view event names to their histogram 50 // GetEventHistogramValue maps guest view event names to their histogram
51 // value. It needs to be like this because the guest view component doesn't 51 // value. It needs to be like this because the guest view component doesn't
52 // know about extensions, so GuestViewEvent can't have an 52 // know about extensions, so GuestViewEvent can't have an
53 // extensions::events::HistogramValue as an argument. 53 // extensions::events::HistogramValue as an argument.
54 events::HistogramValue histogram_value = 54 events::HistogramValue histogram_value =
55 guest_view_events::GetEventHistogramValue(event_name); 55 guest_view_events::GetEventHistogramValue(event_name);
56 DCHECK_NE(events::UNKNOWN, histogram_value) << "Event " << event_name 56 DCHECK_NE(events::UNKNOWN, histogram_value) << "Event " << event_name
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 void ExtensionsGuestViewManagerDelegate::RegisterAdditionalGuestViewTypes() { 99 void ExtensionsGuestViewManagerDelegate::RegisterAdditionalGuestViewTypes() {
100 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_); 100 GuestViewManager* manager = GuestViewManager::FromBrowserContext(context_);
101 manager->RegisterGuestViewType<AppViewGuest>(); 101 manager->RegisterGuestViewType<AppViewGuest>();
102 manager->RegisterGuestViewType<ExtensionOptionsGuest>(); 102 manager->RegisterGuestViewType<ExtensionOptionsGuest>();
103 manager->RegisterGuestViewType<ExtensionViewGuest>(); 103 manager->RegisterGuestViewType<ExtensionViewGuest>();
104 manager->RegisterGuestViewType<MimeHandlerViewGuest>(); 104 manager->RegisterGuestViewType<MimeHandlerViewGuest>();
105 manager->RegisterGuestViewType<WebViewGuest>(); 105 manager->RegisterGuestViewType<WebViewGuest>();
106 } 106 }
107 107
108 } // namespace extensions 108 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/event_listener_map_unittest.cc ('k') | extensions/common/event_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698