Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2937263002: VR: Support loading string resources in unit tests. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
sadrul, agrieve
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Support loading string resources in unit tests. To this point, we haven't needed to test code that relies on translated strings. The URL bar is about to require such a string, so we need to include resource capabilities in the test target. BUG= Review-Url: https://codereview.chromium.org/2937263002 Cr-Commit-Position: refs/heads/master@{#480115} Committed: https://chromium.googlesource.com/chromium/src/+/4d456ff29175aef972c8f24554ec1529afbfe2a7

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove test string used to validate change through the trybots. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -5 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 3 chunks +8 lines, -5 lines 2 comments Download
A chrome/browser/android/vr_shell/run_all_unittests.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
cjgrant
Andrew and Sadrul, this CL aims to let us use translated strings in our unit ...
3 years, 6 months ago (2017-06-15 19:03:55 UTC) #6
agrieve
On 2017/06/15 19:03:55, cjgrant wrote: > Andrew and Sadrul, this CL aims to let us ...
3 years, 6 months ago (2017-06-15 19:32:23 UTC) #7
cjgrant
On 2017/06/15 19:32:23, agrieve wrote: > On 2017/06/15 19:03:55, cjgrant wrote: > > Andrew and ...
3 years, 6 months ago (2017-06-16 14:20:18 UTC) #8
agrieve
On 2017/06/16 14:20:18, cjgrant wrote: > On 2017/06/15 19:32:23, agrieve wrote: > > On 2017/06/15 ...
3 years, 6 months ago (2017-06-16 15:16:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937263002/20001
3 years, 6 months ago (2017-06-16 16:01:13 UTC) #12
sadrul
https://codereview.chromium.org/2937263002/diff/20001/chrome/browser/android/vr_shell/BUILD.gn File chrome/browser/android/vr_shell/BUILD.gn (right): https://codereview.chromium.org/2937263002/diff/20001/chrome/browser/android/vr_shell/BUILD.gn#newcode228 chrome/browser/android/vr_shell/BUILD.gn:228: if (is_android) { This code is in chrome/browser/android/. If ...
3 years, 6 months ago (2017-06-16 16:47:48 UTC) #13
cjgrant
https://codereview.chromium.org/2937263002/diff/20001/chrome/browser/android/vr_shell/BUILD.gn File chrome/browser/android/vr_shell/BUILD.gn (right): https://codereview.chromium.org/2937263002/diff/20001/chrome/browser/android/vr_shell/BUILD.gn#newcode228 chrome/browser/android/vr_shell/BUILD.gn:228: if (is_android) { On 2017/06/16 16:47:48, sadrul wrote: > ...
3 years, 6 months ago (2017-06-16 17:42:03 UTC) #14
sadrul
cool. lgtm
3 years, 6 months ago (2017-06-16 18:39:47 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:01:56 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d456ff29175aef972c8f24554ec...

Powered by Google App Engine
This is Rietveld 408576698