Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/android/vr_shell/BUILD.gn

Issue 2937263002: VR: Support loading string resources in unit tests. (Closed)
Patch Set: Remove test string used to validate change through the trybots. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/run_all_unittests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/BUILD.gn
diff --git a/chrome/browser/android/vr_shell/BUILD.gn b/chrome/browser/android/vr_shell/BUILD.gn
index 32964581f21433230bebb4cac840454691be8ee2..bbf3ea41c72b31b003991e23f35ffde7693595f3 100644
--- a/chrome/browser/android/vr_shell/BUILD.gn
+++ b/chrome/browser/android/vr_shell/BUILD.gn
@@ -201,6 +201,7 @@ test("vr_common_unittests") {
sources = [
"fps_meter_unittest.cc",
"gltf_parser_unittest.cc",
+ "run_all_unittests.cc",
"test/paths.cc",
"test/paths.h",
"textures/close_button_texture_unittest.cc",
@@ -213,8 +214,8 @@ test("vr_common_unittests") {
deps = [
":vr_common",
- "//base/test:run_all_unittests",
"//base/test:test_support",
+ "//components:components_tests_pak",
"//components/security_state/core",
"//skia",
"//testing/gmock",
@@ -224,10 +225,12 @@ test("vr_common_unittests") {
"//ui/gl",
]
+ if (is_android) {
sadrul 2017/06/16 16:47:48 This code is in chrome/browser/android/. If this b
cjgrant 2017/06/16 17:42:03 Indeed it should. We're soon to migrate this out
+ deps += [ "//ui/android:ui_java" ]
+ }
+
data = [
- "test/data/sample_inline.gltf",
- "test/data/sample_external.gltf",
- "test/data/sample.bin",
- "test/data/sample.glb",
+ "test/data/",
+ "$root_out_dir/components_tests_resources.pak",
]
}
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/run_all_unittests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698