Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/chromeos/device/input_service_proxy.h

Issue 2937253003: cros: Replace BrowserThread::FILE in InputServiceProxy (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/device/input_service_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/device/input_service_proxy.h
diff --git a/chrome/browser/chromeos/device/input_service_proxy.h b/chrome/browser/chromeos/device/input_service_proxy.h
index 3c00da6e381eebf32ed42eabca038795c4c45f47..c78c62359ebb4846279f912f403e726060fda3fa 100644
--- a/chrome/browser/chromeos/device/input_service_proxy.h
+++ b/chrome/browser/chromeos/device/input_service_proxy.h
@@ -14,7 +14,6 @@
#include "base/observer_list.h"
#include "base/task_runner.h"
#include "base/threading/thread_checker.h"
-#include "content/public/browser/browser_thread.h"
#include "device/hid/input_service_linux.h"
namespace chromeos {
@@ -48,11 +47,11 @@ class InputServiceProxy {
const GetDeviceInfoCallback& callback);
// Should be called once before any InputServiceProxy instance is created.
achuithb 2017/06/15 23:04:59 Should we move this comment after the using declar
xiyuan 2017/06/16 19:21:27 will do
- static void SetThreadIdForTesting(content::BrowserThread::ID thread_id);
+ using TaskRunnerFactory =
+ base::Callback<scoped_refptr<base::TaskRunner>(void)>;
achuithb 2017/06/15 23:04:59 I'm curious if this is the standard pattern now fo
xiyuan 2017/06/16 19:21:27 Not a standard pattern. I used this because it fit
+ static void SetTaskRunnerFactoryForTesting(TaskRunnerFactory* factory);
private:
- static content::BrowserThread::ID thread_identifier_;
-
class ServiceObserver;
void OnDeviceAdded(const device::InputServiceLinux::InputDeviceInfo& info);
« no previous file with comments | « no previous file | chrome/browser/chromeos/device/input_service_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698