Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2937083002: Revert of Forward BrowserAccessibility get_accState to AXPlatformNode. (Closed)

Created:
3 years, 6 months ago by dmazzoni
Modified:
3 years, 6 months ago
Reviewers:
dougt
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Forward BrowserAccessibility get_accState to AXPlatformNode. (patchset #5 id:80001 of https://codereview.chromium.org/2913553002/ ) Reason for revert: READONLY state missing, breaks screen reader virtual buffers Original issue's description: > Forward BrowserAccessibility get_accState to AXPlatformNode. > > This is another migration from BrowserAccessibility to AXPlatformNodeWin. > In this installment, we're converting get_accState. This one is mostly > straightforward. The one gotcha is that there are some types that need > to be explictly marked as focusable if they are selectable. > > BUG=703369 > > Review-Url: https://codereview.chromium.org/2913553002 > Cr-Commit-Position: refs/heads/master@{#478110} > Committed: https://chromium.googlesource.com/chromium/src/+/2396b649beff6d478edff6334af2305418cc3c45 TBR=dougt@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=703369, 733313 Review-Url: https://codereview.chromium.org/2937083002 Cr-Commit-Position: refs/heads/master@{#479448} Committed: https://chromium.googlesource.com/chromium/src/+/f29d6038c0a838d1eb2e94536634b6bc83a068b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -137 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 chunk +17 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 3 chunks +2 lines, -101 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
dmazzoni
Created Revert of Forward BrowserAccessibility get_accState to AXPlatformNode.
3 years, 6 months ago (2017-06-14 17:04:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937083002/1
3 years, 6 months ago (2017-06-14 17:05:36 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 18:28:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f29d6038c0a838d1eb2e94536634...

Powered by Google App Engine
This is Rietveld 408576698