Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2913553002: Forward BrowserAccessibility get_accState to AXPlatformNode. (Closed)

Created:
3 years, 6 months ago by dougt
Modified:
3 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward BrowserAccessibility get_accState to AXPlatformNode. This is another migration from BrowserAccessibility to AXPlatformNodeWin. In this installment, we're converting get_accState. This one is mostly straightforward. The one gotcha is that there are some types that need to be explictly marked as focusable if they are selectable. BUG=703369 Review-Url: https://codereview.chromium.org/2913553002 Cr-Commit-Position: refs/heads/master@{#478110} Committed: https://chromium.googlesource.com/chromium/src/+/2396b649beff6d478edff6334af2305418cc3c45

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : linux needs love too #

Total comments: 1

Patch Set 4 : rebase #

Patch Set 5 : rename and switch boolean values #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -19 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 2 3 1 chunk +1 line, -17 lines 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 2 3 4 3 chunks +101 lines, -2 lines 1 comment Download
M ui/accessibility/platform/test_ax_node_wrapper.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
dougt
ptal
3 years, 6 months ago (2017-05-29 05:08:50 UTC) #14
dmazzoni
lgtm https://codereview.chromium.org/2913553002/diff/40001/content/browser/accessibility/browser_accessibility.h File content/browser/accessibility/browser_accessibility.h (right): https://codereview.chromium.org/2913553002/diff/40001/content/browser/accessibility/browser_accessibility.h#newcode410 content/browser/accessibility/browser_accessibility.h:410: bool IsHotTrackingOn() override; This should more clearly say ...
3 years, 6 months ago (2017-06-06 04:50:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913553002/80001
3 years, 6 months ago (2017-06-08 20:44:46 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/2396b649beff6d478edff6334af2305418cc3c45
3 years, 6 months ago (2017-06-08 22:49:01 UTC) #25
dmazzoni
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2937083002/ by dmazzoni@chromium.org. ...
3 years, 6 months ago (2017-06-14 17:04:55 UTC) #26
dmazzoni
https://codereview.chromium.org/2913553002/diff/80001/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2913553002/diff/80001/ui/accessibility/platform/ax_platform_node_win.cc#newcode1582 ui/accessibility/platform/ax_platform_node_win.cc:1582: GetData().role != ROLE_SYSTEM_DOCUMENT && This is the bug. GetData().role ...
3 years, 6 months ago (2017-06-14 17:13:17 UTC) #27
dmazzoni
3 years, 6 months ago (2017-06-15 06:08:36 UTC) #29
Message was sent while issue was closed.
Not sure if you meant to reopen, but let's create a new changelist
to re-land this one, and just refer to this changelist in the
description, thanks.

Powered by Google App Engine
This is Rietveld 408576698