CSS Properties & Values API: Compute initial values for transfrom-list type.

CSS Properties & Values API: Compute initial values for transfrom-list type.

For <transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-computed-values

BUG=671490
Review-Url: https://codereview.chromium.org/2937043002
Cr-Commit-Position: refs/heads/master@{#483312}
Committed: https://chromium.googlesource.com/chromium/src/+/53b56ec80be3c1b18df487c03963416a1313d6c5

[Hwanseung Lee, 2017-06-14 14:08:07]

Description was changed from

==========
[custom-properties] Compute initial values for transfrom-function type.

BUG=671490
==========

to

==========
[custom-properties] Compute initial values for transfrom-function type.

BUG=671490
==========

[Hwanseung Lee, 2017-06-24 00:16:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 00:16:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 02:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 02:04:44]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-06-24 02:55:33]

Description was changed from

==========
[custom-properties] Compute initial values for transfrom-function type.

BUG=671490
==========

to

==========
CSS Properties & Values API: Compute initial values for transfrom-list type.

For <<transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-co...

BUG=671490
==========

[Hwanseung Lee, 2017-06-24 02:56:01]

Description was changed from

==========
CSS Properties & Values API: Compute initial values for transfrom-list type.

For <<transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-co...

BUG=671490
==========

to

==========
CSS Properties & Values API: Compute initial values for transfrom-list type.

For <transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-co...

BUG=671490
==========

[Hwanseung Lee, 2017-06-25 23:31:48]

hs1217.lee@samsung.com changed reviewers:
+ meade@chromium.org

[Hwanseung Lee, 2017-06-25 23:31:48]

@meade
PTAL, thank you.

[meade_UTC10, 2017-06-28 07:20:03]

https://codereview.chromium.org/2937043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):

https://codereview.chromium.org/2937043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/PropertyRegistration.cpp:66: if
(value.IsFunctionValue()) {
CSSFunctionValue inherits from CSSValueList, and from reading the code, this
should never be reached. Does it still work if you remove this bit?

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSVa...

[Hwanseung Lee, 2017-06-28 12:40:02]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 12:40:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 14:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 14:31:13]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-06-28 23:37:31]

https://codereview.chromium.org/2937043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):

https://codereview.chromium.org/2937043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/PropertyRegistration.cpp:66: if
(value.IsFunctionValue()) {
On 2017/06/28 07:20:03, meade_UTC10 wrote:
> CSSFunctionValue inherits from CSSValueList, and from reading the code, this
> should never be reached. Does it still work if you remove this bit?
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSVa...
> 
it is working well without these lines.
i removed them.

[meade_UTC10, 2017-06-29 03:29:29]

lgtm

[Hwanseung Lee, 2017-06-29 06:44:34]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-06-29 06:44:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 06:49:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498718674047380,
"parent_rev": "cf3713102fb05816d3e8385a122b6ce46737992b", "commit_rev":
"53b56ec80be3c1b18df487c03963416a1313d6c5"}

[commit-bot: I haz the power, 2017-06-29 06:50:04]

Description was changed from

==========
CSS Properties & Values API: Compute initial values for transfrom-list type.

For <transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-co...

BUG=671490
==========

to

==========
CSS Properties & Values API: Compute initial values for transfrom-list type.

For <transform-function> values contained in <transform-list> values,
the computed value is as specified but with all lengths resolved to
their computed values.

https://drafts.css-houdini.org/css-properties-values-api-1/#calculation-of-co...

BUG=671490

Review-Url: https://codereview.chromium.org/2937043002
Cr-Commit-Position: refs/heads/master@{#483312}
Committed:
https://chromium.googlesource.com/chromium/src/+/53b56ec80be3c1b18df487c03963...
==========

[commit-bot: I haz the power, 2017-06-29 06:50:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/53b56ec80be3c1b18df487c03963...