CSS Properties & Values API: Compute initial values for transfrom-list type.

third_party/WebKit/Source/core/css/PropertyRegistration.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/PropertyRegistration.h"
 
 #include "core/animation/CSSInterpolationTypesMap.h"
 #include "core/css/CSSStyleSheet.h"
 #include "core/css/CSSSyntaxDescriptor.h"
 #include "core/css/CSSValueList.h"
@@ skipping 45 matching lines @@
                 ->NeedsVariableResolution();
 
   if (value.IsValueList()) {
     for (const CSSValue* inner_value : ToCSSValueList(value)) {
       if (!ComputationallyIndependent(*inner_value))
         return false;
     }
     return true;
   }
 
+  if (value.IsFunctionValue()) {

[meade_UTC10, 2017/06/28 07:20:03]

CSSFunctionValue inherits from CSSValueList, and from reading the code, this
should never be reached. Does it still work if you remove this bit?

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSVa...

[Hwanseung Lee, 2017/06/28 23:37:31]

it is working well without these lines.
i removed them.

+    for (const CSSValue* inner_value : ToCSSFunctionValue(value)) {
+      if (!ComputationallyIndependent(*inner_value)) {
+        return false;
+      }
+    }
+    return true;
+  }
+
   if (value.IsPrimitiveValue()) {
     const CSSPrimitiveValue& primitive_value = ToCSSPrimitiveValue(value);
     if (!primitive_value.IsLength() &&
         !primitive_value.IsCalculatedPercentageWithLength())
       return true;
 
     CSSPrimitiveValue::CSSLengthArray length_array;
     primitive_value.AccumulateLengthArray(length_array);
     for (size_t i = 0; i < length_array.values.size(); i++) {
       if (length_array.type_flags.Get(i) &&
           i != CSSPrimitiveValue::kUnitTypePixels &&
           i != CSSPrimitiveValue::kUnitTypePercentage)
         return false;
     }
     return true;
   }
 
-  // TODO(timloh): Images and transform-function values can also contain
-  // lengths.
+  // TODO(timloh): Images values can also contain lengths.
 
   return true;
 }
 
 void PropertyRegistration::registerProperty(
     ExecutionContext* execution_context,
     const PropertyDescriptor& descriptor,
     ExceptionState& exception_state) {
   // Bindings code ensures these are set.
   DCHECK(descriptor.hasName());
@@ skipping 66 matching lines @@
                               std::move(css_interpolation_types));
   }
 
   // TODO(timloh): Invalidate only elements with this custom property set
   document->SetNeedsStyleRecalc(kSubtreeStyleChange,
                                 StyleChangeReasonForTracing::Create(
                                     StyleChangeReason::kPropertyRegistration));
 }
 
 }  // namespace blink