Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)
Patch Set: UMA fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 98100d29dd9e23c216cf0226dd1ac84c2dddbe5a..8bd66d2881a20eb8ec490f13d89802db71662844 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -565,6 +565,24 @@ void PasswordFormManager::Update(
old_primary_key ? &old_primary_key.value() : nullptr);
}
+void PasswordFormManager::PresaveGeneratedPassword(
vabr (Chromium) 2017/06/16 12:32:29 Could we test the two newly added methods in the u
kolos1 2017/06/21 13:46:12 Done.
+ const autofill::PasswordForm& form) {
+ form_saver()->PresaveGeneratedPassword(form);
+ if (has_generated_password_) {
+ generated_password_changed_ = true;
+ } else {
+ has_generated_password_ = true;
+ generated_password_changed_ = false;
+ }
+}
+
+void PasswordFormManager::PasswordNoLongerGenerated() {
+ DCHECK(has_generated_password_);
+ form_saver()->RemovePresavedPassword();
+ has_generated_password_ = false;
+ generated_password_changed_ = false;
+}
+
void PasswordFormManager::SetSubmittedForm(const autofill::PasswordForm& form) {
bool is_change_password_form =
!form.new_password_value.empty() && !form.password_value.empty();
@@ -975,6 +993,7 @@ void PasswordFormManager::AddGeneratedVote(
autofill::AutofillField* field = form_structure->field(i);
if (field->name == generation_element_) {
field->set_generation_type(type);
+ field->set_generated_password_changed(generated_password_changed_);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698